feature/migrate-IexecPoco-to-ethers6 #196
Conversation
Le-Caignec
changed the title
Le-Caignec
requested review from
james-toussaint,
zguesmi and
gfournieriExec
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Co-authored-by: Jérémy (James) Toussaint <33313130+jeremyjams@users.noreply.github.com>
test/byContract/IexecPoco/IexecPoco2-contribute-and-finalize.test.ts
Outdated
Show resolved
Hide resolved
test/byContract/IexecPoco/IexecPoco2-contribute-and-finalize.test.ts
Outdated
Show resolved
Hide resolved
| iexecPoco, | ||
| [requester, sponsor, appProvider, datasetProvider], | ||
| [ | ||
| 0, // requester balance is unchanged, only frozen is changed |
There was a problem hiding this comment.
I think we can harmonize, 0 or 0n everywhere
There was a problem hiding this comment.
Some Number castings are still present in the code. Removing them in another PR might reveal the need to add explicit castings for some cases. I have only changed the ones that are actually consumed and where BigInt is required. I have minimized the changes as much as possible.
…est.ts Co-authored-by: Jérémy (James) Toussaint <33313130+jeremyjams@users.noreply.github.com>
…est.ts Co-authored-by: Jérémy (James) Toussaint <33313130+jeremyjams@users.noreply.github.com>
Co-authored-by: Jérémy (James) Toussaint <33313130+jeremyjams@users.noreply.github.com>
…nto feature/migrate-IexecPoco-to-ethers6
| // const appOrderConsumedSlotIndex = ethers.keccak256( | ||
| // ethers.concat([ |
There was a problem hiding this comment.
That's funny to update even the comments
Co-authored-by: gfournieriExec <100280020+gfournieriExec@users.noreply.github.com>
| requester: requester.address, | ||
| prices: ordersPrices, | ||
| volume, | ||
| trust: 3, |
There was a problem hiding this comment.
we don't want to migrate the trust as well in bigint ?
There was a problem hiding this comment.
yes it think but I have only changed lines/variables that are actually consumed and where BigInt is required. I have minimized the changes as much as possible.
…tools" This reverts commit cd14b8d.
…ss in IexecPoco2 finalize tests
No description provided.