migrate Poco Boost test folder to ethers6 #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfournieriExec
requested review from
zguesmi,
james-toussaint and
Le-Caignec
Le-Caignec
reviewed
Feb 19, 2025
Le-Caignec
approved these changes
Feb 19, 2025
james-toussaint
approved these changes
Feb 20, 2025
zguesmi
reviewed
Feb 20, 2025
| function computeSchedulerDealStake(workerpoolPrice: number, volume: number) { | ||
| return ((workerpoolPrice * workerpoolStakeRatio) / 100) * volume; | ||
| function computeSchedulerDealStake(workerpoolPrice: bigint, volume: bigint) { | ||
| return (workerpoolPrice * workerpoolStakeRatio * volume) / 100n; |
There was a problem hiding this comment.
Careful the order is important here.
Suggested change
| return (workerpoolPrice * workerpoolStakeRatio * volume) / 100n; | |
| // Order is important here. | |
| return ((workerpoolPrice * workerpoolStakeRatio) / 100n) * volume; |
zguesmi
approved these changes
Feb 20, 2025
…nto feature/migrate-boost-tests-ethers6
james-toussaint
merged commit 9e2925c
into
feature/migration-to-ether-v6
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.