Migrate escrow tests to Ethers v6 #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w-migr-to-ethers-v6
This reverts commit 4a94fff.
zguesmi
changed the title
zguesmi
commented
Feb 18, 2025
Comment on lines
-191
to
-198
| await expect(iexecPocoAsAccountA.depositForArray(...depositForArrayArgs)) | ||
| .to.changeTokenBalances( | ||
| rlcInstance, | ||
| [accountA, iexecPoco], | ||
| [-depositTotalAmount, depositTotalAmount], | ||
| ) | ||
| const tx = iexecPocoAsAccountA.depositForArray(...depositForArrayArgs); | ||
| await expect(tx).to.changeTokenBalances( | ||
| rlcInstance, | ||
| [accountA, iexecPoco], | ||
| [-depositTotalAmount, depositTotalAmount], | ||
| ); | ||
| await expect(tx) | ||
| .to.emit(rlcInstance, 'Transfer') | ||
| .withArgs(accountA.address, iexecPoco, depositTotalAmount) |
There was a problem hiding this comment.
This assertion is incorrect because there is never a transfer with the full depositTotalAmount. The check was not being executed because it's chained to to.changeTokenBalances(). It's fixed in this PR.
zguesmi
requested review from
james-toussaint,
gfournieriExec and
Le-Caignec
Le-Caignec
reviewed
Feb 19, 2025
CHANGELOG.md
Outdated
| - Deployment scripts (#187) | ||
| - Tests | ||
| - IexecEscrow (#199) | ||
| - ENSIntegration, IexecOrderManagement, IexecRelay (#195) |
There was a problem hiding this comment.
Suggested change
| - ENSIntegration, IexecOrderManagement, IexecRelay (#195) | |
| - ENSIntegration, IexecOrderManagement, IexecRelay (#195, #199) |
CHANGELOG.md
Outdated
| - Tests | ||
| - IexecEscrow (#199) | ||
| - ENSIntegration, IexecOrderManagement, IexecRelay (#195) | ||
| - IexecCategoryManager, IexecERC20 (#192) |
There was a problem hiding this comment.
Suggested change
| - IexecCategoryManager, IexecERC20 (#192) | |
| - IexecCategoryManager, IexecERC20 (#192, #199) |
CHANGELOG.md
Outdated
| - IexecCategoryManager, IexecERC20 (#192) | ||
| - test/*fullchain* (#190) | ||
| - IexecAccessors (#189, #191) | ||
| - IexecAccessors, IexecMaintenance (#189, #191) |
There was a problem hiding this comment.
Suggested change
| - IexecAccessors, IexecMaintenance (#189, #191) | |
| - IexecAccessors, IexecMaintenance (#189, #191, #199) |
Comment on lines
+5
to
+12
| export async function hashDomain(domain: IexecLibOrders_v5.EIP712DomainStructOutput) { | ||
| return ethers.TypedDataEncoder.hashDomain({ | ||
| name: domain.name, | ||
| version: domain.version, | ||
| chainId: domain.chainId, | ||
| verifyingContract: domain.verifyingContract, | ||
| }); | ||
| } |
There was a problem hiding this comment.
i think we can remove buildDomain function if we have that
package.json
Outdated
| "sol2uml": "After 2.5.19, see https://github.com/naddison36/sol2uml/issues/183" | ||
| } | ||
| } | ||
| } |
test/utils/utils.ts
Outdated
| * | ||
| * Note: sending ETH to address(0) does not increment its balance. | ||
| */ | ||
| export async function setZeroAddressBalance(amount: bigint) { |
There was a problem hiding this comment.
Set 10n input by default ?
Le-Caignec
approved these changes
Feb 20, 2025
…w-migr-to-ethers-v6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next PR:
scripts/test/run-native-tests.sh.