Skip to content

feature/ethers6-migration-use-bigint-instead-number #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025
Merged

feature/ethers6-migration-use-bigint-instead-number #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b21f4b
Update tests and utility functions to use bigint for category index a…
Le-Caignec Feb 20, 2025
4247bf5
Update CHANGELOG to include IexecWrapper in the list of tests
Le-Caignec Feb 20, 2025
286ae38
Fix minor issue in BigInt for IexecWrapper in CHANGELOG
Le-Caignec Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@
- Tests
- IexecEscrow (#199)
- ENSIntegration, IexecOrderManagement, IexecRelay (#195, #199)
- IexecCategoryManager, IexecERC20 (#192, #199)
- IexecCategoryManager, IexecERC20 (#192, #199, #202)
- test/*fullchain* (#190, #196)
- IexecAccessors, IexecMaintenance (#189, #191, #199)
- IexecPoco (#196)
- `trust` specific field (#201)
- IexecPocoBoost (#198)
- fixed a minor issue in BigInt for IexecWrapper (#202).
- Migrate scripts to TypeScript: (#184)
- `getFunctionSignatures.js`, `common-test-snapshot.js`, `test-storage.js`, `timelock.js`
- Migrated utility files to TypeScript : (#183)
Expand Down
4 changes: 2 additions & 2 deletions test/byContract/IexecCategoryManager/IexecCategoryManager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ describe('CategoryManager', async () => {
});

it('Should not view category with bad index', async () => {
const lastCategoryIndex = Number(await iexecPocoAsAnyone.countCategory()) - 1;
const lastCategoryIndex = (await iexecPocoAsAnyone.countCategory()) - 1n;
await expect(
iexecPocoAsAnyone.viewCategory(lastCategoryIndex + 1),
iexecPocoAsAnyone.viewCategory(lastCategoryIndex + 1n),
).to.be.revertedWithoutReason();
});

Expand Down
10 changes: 4 additions & 6 deletions test/utils/IexecWrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,12 +151,10 @@ export class IexecWrapper {
* @returns value of the reward
*/
async getSchedulerRewardRatio(workerpoolAddress: string) {
return Number(
await Workerpool__factory.connect(
workerpoolAddress,
this.accounts.anyone,
).m_schedulerRewardRatioPolicy(),
);
return await Workerpool__factory.connect(
workerpoolAddress,
this.accounts.anyone,
).m_schedulerRewardRatioPolicy();
}

/**
Expand Down