Feature gitHub actions deployment pipeline #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #218 +/- ##
========================================
Coverage 84.50% 84.50%
========================================
Files 35 35
Lines 1084 1084
Branches 221 221
========================================
Hits 916 916
Misses 168 168 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Le-Caignec
requested changes
May 5, 2025
README.md
Outdated
Comment on lines
179
to
183
| ### Automated Verification via GitHub Actions | ||
| The GitHub Actions workflow automatically handles contract verification after deployment. It waits 60 seconds for the contracts to be indexed by the block explorer before attempting verification. | ||
| The verification process uses the same script (`./scripts/verify.ts`) that reads deployment artifacts to verify each contract with its correct constructor arguments. |
There was a problem hiding this comment.
zguesmi
reviewed
May 5, 2025
…cation sections from README
…they are made from the main branch
zguesmi
reviewed
May 6, 2025
…bitrum Sepolia networks
…eters and improving error handling
…n ID retrieval and improve error handling
…nfiguration handling
Le-Caignec
approved these changes
May 6, 2025
zguesmi
reviewed
May 12, 2025
zguesmi
reviewed
May 12, 2025
…g.js and retrieve it directly from hre.network
…oyment configuration and improve error handling
…538Proxy and change asset default to 'Token'
…ve redundant comment in update-config.ts
…n update-config.ts
zguesmi
approved these changes
May 12, 2025
scripts/tools/update-config.ts
Outdated
Comment on lines
17
to
21
| const deploymentPath = path.resolve(`deployments/${networkName}/ERC1538Proxy.json`); | ||
| if (!fs.existsSync(deploymentPath)) { | ||
| console.error(`ERC1538Proxy deployment file not found for network: ${networkName}`); | ||
| process.exit(1); | ||
| } |
There was a problem hiding this comment.
Suggested change
| const deploymentPath = path.resolve(`deployments/${networkName}/ERC1538Proxy.json`); | |
| if (!fs.existsSync(deploymentPath)) { | |
| console.error(`ERC1538Proxy deployment file not found for network: ${networkName}`); | |
| process.exit(1); | |
| } |
… in update-config.ts
This was referenced Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.