Skip to content

Conversation

gfournieriExec
Copy link
Contributor

Split de la PR #226 : #226 en 3

  • renommer toutes les occurence de 1538
  • renommer les fichiers,
  • nettoyer ce qu'on veut

@gfournieriExec gfournieriExec marked this pull request as ready for review July 25, 2025 13:30
@gfournieriExec gfournieriExec self-assigned this Jul 25, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates naming throughout the codebase to replace "ERC1538" references with "Diamond proxy" terminology, reflecting a migration from ERC1538 proxy pattern to Diamond proxy pattern. This appears to be part 1 of a larger refactoring effort.

  • Replace all occurrences of "ERC1538" with "Diamond" or "DiamondProxy" in variable names, comments, and configuration
  • Update deployment and configuration scripts to use new Diamond proxy naming
  • Maintain backward compatibility by keeping deprecated ERC1538Proxy config field

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
utils/proxy-tools.ts Update comments to reference Diamond proxy instead of ERC1538
utils/config.ts Add DiamondProxy config field while keeping deprecated ERC1538Proxy
test/utils/hardhat-fixture-deployer.ts Replace ERC1538Proxy references with DiamondProxy in test setup
test/utils/fixture-helpers.ts Update ownership transfer functions to use DiamondProxy
scripts/upgrades/upgrade-helper.ts Rename variables and comments from erc1538 to diamond terminology
scripts/tools/update-config.ts Update deployment getter to use DiamondProxy instead of ERC1538Proxy
scripts/sponsoring/1_add-modules-to-proxy.ts Replace ERC1538Proxy variables with DiamondProxy throughout
scripts/set-callback-gas.ts Update deployment getter to use DiamondProxy
scripts/boost/1_add-modules-to-proxy.ts Replace ERC1538Proxy references with DiamondProxy
deploy/0_deploy.ts Update variable names and comments from erc1538 to diamond terminology
config/config.json Replace ERC1538Proxy key with DiamondProxy in configuration
.github/workflows/deploy-smart-contracts.yml Update workflow comment to reference Diamond proxy
Comments suppressed due to low confidence (1)

scripts/upgrades/upgrade-helper.ts:33

  • [nitpick] The variable name 'diamondQueryInstance' suggests it should be a Diamond-related type, but it's still using 'ERC1538Query'. Consider updating the type name to match the Diamond pattern or using a more generic name like 'queryInstance'.
    const diamondQueryInstance: ERC1538Query = ERC1538Query__factory.connect(

Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (287cc9c) to head (1806a0f).
Report is 1 commits behind head on feature/diamond.

Additional details and impacted files
@@               Coverage Diff                @@
##           feature/diamond     #229   +/-   ##
================================================
  Coverage            83.85%   83.85%           
================================================
  Files                   36       36           
  Lines                 1109     1109           
  Branches               225      225           
================================================
  Hits                   930      930           
  Misses                 179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Robin Le Caignec <72495599+Le-Caignec@users.noreply.github.com>
@gfournieriExec gfournieriExec merged commit c83fed7 into feature/diamond Jul 25, 2025
4 checks passed
@gfournieriExec gfournieriExec deleted the feature/rename-part-1 branch July 25, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants