-
Notifications
You must be signed in to change notification settings - Fork 14
Format all solidity files #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR formats all Solidity files in the codebase to standardize code style and improve consistency. The formatting includes updating copyright headers, standardizing import statements, adjusting whitespace and indentation, and converting multi-line comments to single-line copyright headers.
Key changes:
- Updated copyright years to "2020-2025" for most files and adjusted year ranges for newer files
- Standardized SPDX copyright headers format
- Converted block comment copyright headers to single-line SPDX format
- Normalized import statement formatting (single vs double quotes)
- Standardized code formatting including brace placement, parameter alignment, and whitespace
Reviewed Changes
Copilot reviewed 67 out of 67 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
contracts/tools/testing/TestReceiver.sol | Replaced block copyright header with SPDX format, reformatted code structure |
contracts/tools/testing/TestClient.sol | Updated copyright header and cleaned up formatting |
contracts/tools/TimelockController.sol | Added SPDX copyright header and changed license from MIT to Apache-2.0 |
contracts/registries/workerpools/WorkerpoolRegistry.sol | Updated copyright header, reformatted imports and function parameters |
contracts/registries/workerpools/Workerpool.sol | Standardized header and improved parameter formatting |
Multiple interface and facet files | Updated copyright years and standardized formatting across all files |
CHANGELOG.md | Added entry documenting the formatting changes |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/diamond #233 +/- ##
================================================
Coverage 82.90% 82.90%
================================================
Files 36 36
Lines 1123 1123
Branches 225 225
================================================
Hits 931 931
Misses 192 192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Migration steps:
receive
andfallback
behavior inDiamond.sol
Module
toFacet
in contracts namesDiamond.sol