Skip to content

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Jul 25, 2025

Migration steps:

  • Migrate src files (minimal changes)
  • Modify receive and fallback behavior in Diamond.sol
  • Rename all 1538 to 2535 in contracts and rename Module to Facet in contracts names
  • Update all facets to use namespaces app storage.
  • Remove ENSIntegration modules/functions
  • Set admin in deployment script
  • Update docs (soldoc, diagrams, ...)
  • Add unit tests for Diamond.sol
  • Update contracts source code structure.

@zguesmi zguesmi marked this pull request as ready for review July 25, 2025 16:59
@zguesmi zguesmi self-assigned this Jul 25, 2025
Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zguesmi zguesmi requested a review from Copilot July 25, 2025 17:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR formats all Solidity files in the codebase to standardize code style and improve consistency. The formatting includes updating copyright headers, standardizing import statements, adjusting whitespace and indentation, and converting multi-line comments to single-line copyright headers.

Key changes:

  • Updated copyright years to "2020-2025" for most files and adjusted year ranges for newer files
  • Standardized SPDX copyright headers format
  • Converted block comment copyright headers to single-line SPDX format
  • Normalized import statement formatting (single vs double quotes)
  • Standardized code formatting including brace placement, parameter alignment, and whitespace

Reviewed Changes

Copilot reviewed 67 out of 67 changed files in this pull request and generated no comments.

Show a summary per file
File Description
contracts/tools/testing/TestReceiver.sol Replaced block copyright header with SPDX format, reformatted code structure
contracts/tools/testing/TestClient.sol Updated copyright header and cleaned up formatting
contracts/tools/TimelockController.sol Added SPDX copyright header and changed license from MIT to Apache-2.0
contracts/registries/workerpools/WorkerpoolRegistry.sol Updated copyright header, reformatted imports and function parameters
contracts/registries/workerpools/Workerpool.sol Standardized header and improved parameter formatting
Multiple interface and facet files Updated copyright years and standardized formatting across all files
CHANGELOG.md Added entry documenting the formatting changes

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.90%. Comparing base (b6a5a16) to head (8988fd0).
⚠️ Report is 4 commits behind head on feature/diamond.

Additional details and impacted files
@@               Coverage Diff                @@
##           feature/diamond     #233   +/-   ##
================================================
  Coverage            82.90%   82.90%           
================================================
  Files                   36       36           
  Lines                 1123     1123           
  Branches               225      225           
================================================
  Hits                   931      931           
  Misses                 192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zguesmi zguesmi merged commit 5544abf into feature/diamond Jul 25, 2025
4 of 5 checks passed
@zguesmi zguesmi deleted the feature/formatting branch July 25, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants