-
Notifications
You must be signed in to change notification settings - Fork 14
feat: rename-part-3 #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename-part-3 #234
Conversation
…e contracts and tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR is part 3 of a larger refactoring effort that renames IexecMaintenance
to IexecConfiguration
throughout the codebase. The changes update interface names, class names, factory imports, and related references to use the new naming convention.
- Updates all imports and references from
IexecMaintenance*
toIexecConfiguration*
- Renames contract classes and their corresponding factory imports
- Updates variable declarations and instantiations to use the new naming
- Fixes a typo in a comment from "DiamonLoup" to "DiamondLoup"
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
test/utils/IexecWrapper.ts | Updates factory import and connection call to use IexecConfigurationFacet |
test/byContract/IexecPocoBoost/IexecPocoBoost.test.ts | Updates imports and variable declarations for IexecConfiguration |
test/byContract/IexecMaintenance/IexecMaintenance.test.ts | Renames test suite and updates all IexecMaintenance references to IexecConfiguration |
scripts/upgrades/upgrade-helper.ts | Fixes typo in comment from "DiamonLoup" to "DiamondLoup" |
scripts/set-callback-gas.ts | Updates factory import and usage to IexecConfigurationFacet |
deploy/0_deploy.ts | Updates factory imports and instantiations for configuration facets |
contracts/modules/interfaces/IexecConfigurationExtra.sol | Renames interface from IexecMaintenanceExtra to IexecConfigurationExtra |
contracts/modules/interfaces/IexecConfiguration.sol | Renames interface from IexecMaintenance to IexecConfiguration |
contracts/modules/facets/IexecConfigurationFacet.sol | Renames contract class and updates interface import |
contracts/modules/facets/IexecConfigurationExtraFacet.sol | Renames contract class and updates interface import |
contracts/Store.v8.sol | Updates comments referencing the renamed facet |
contracts/IexecInterfaceTokenABILegacy.sol | Updates interface import and inheritance |
contracts/IexecInterfaceToken.sol | Updates interface import and inheritance |
contracts/IexecInterfaceNativeABILegacy.sol | Updates interface import and inheritance |
contracts/IexecInterfaceNative.sol | Updates interface import and inheritance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/diamond #234 +/- ##
================================================
Coverage 82.90% 82.90%
================================================
Files 36 36
Lines 1123 1123
Branches 225 225
================================================
Hits 931 931
Misses 192 192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fix => Commit: 1f51bf4 |
Split de la PR #226 : #226 en 3
-
IexecMaintenanceFacet
=>IexecConfigurationFacet
✔