Skip to content

Conversation

Le-Caignec
Copy link
Contributor

@Le-Caignec Le-Caignec commented Jul 25, 2025

Split de la PR #226 : #226 en 3

  • renommer toutes les occurence de 1538
  • renommer les fichiers,
  • nettoyer ce qu'on veut :
    - IexecMaintenanceFacet => IexecConfigurationFacet

@Le-Caignec Le-Caignec changed the title feat: replace IexecMaintenance with IexecConfiguration across multipl… feat:rename-part-3 Jul 25, 2025
@Le-Caignec Le-Caignec changed the title feat:rename-part-3 feat: rename-part-3 Jul 25, 2025
@Le-Caignec Le-Caignec self-assigned this Jul 25, 2025
@Le-Caignec Le-Caignec marked this pull request as draft July 25, 2025 17:14
Base automatically changed from feature/formatting to feature/diamond July 25, 2025 17:15
@Le-Caignec Le-Caignec marked this pull request as ready for review July 25, 2025 17:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is part 3 of a larger refactoring effort that renames IexecMaintenance to IexecConfiguration throughout the codebase. The changes update interface names, class names, factory imports, and related references to use the new naming convention.

  • Updates all imports and references from IexecMaintenance* to IexecConfiguration*
  • Renames contract classes and their corresponding factory imports
  • Updates variable declarations and instantiations to use the new naming
  • Fixes a typo in a comment from "DiamonLoup" to "DiamondLoup"

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/utils/IexecWrapper.ts Updates factory import and connection call to use IexecConfigurationFacet
test/byContract/IexecPocoBoost/IexecPocoBoost.test.ts Updates imports and variable declarations for IexecConfiguration
test/byContract/IexecMaintenance/IexecMaintenance.test.ts Renames test suite and updates all IexecMaintenance references to IexecConfiguration
scripts/upgrades/upgrade-helper.ts Fixes typo in comment from "DiamonLoup" to "DiamondLoup"
scripts/set-callback-gas.ts Updates factory import and usage to IexecConfigurationFacet
deploy/0_deploy.ts Updates factory imports and instantiations for configuration facets
contracts/modules/interfaces/IexecConfigurationExtra.sol Renames interface from IexecMaintenanceExtra to IexecConfigurationExtra
contracts/modules/interfaces/IexecConfiguration.sol Renames interface from IexecMaintenance to IexecConfiguration
contracts/modules/facets/IexecConfigurationFacet.sol Renames contract class and updates interface import
contracts/modules/facets/IexecConfigurationExtraFacet.sol Renames contract class and updates interface import
contracts/Store.v8.sol Updates comments referencing the renamed facet
contracts/IexecInterfaceTokenABILegacy.sol Updates interface import and inheritance
contracts/IexecInterfaceToken.sol Updates interface import and inheritance
contracts/IexecInterfaceNativeABILegacy.sol Updates interface import and inheritance
contracts/IexecInterfaceNative.sol Updates interface import and inheritance

Copy link
Member

@zguesmi zguesmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this

image

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.90%. Comparing base (5544abf) to head (1f51bf4).
⚠️ Report is 1 commits behind head on feature/diamond.

Additional details and impacted files
@@               Coverage Diff                @@
##           feature/diamond     #234   +/-   ##
================================================
  Coverage            82.90%   82.90%           
================================================
  Files                   36       36           
  Lines                 1123     1123           
  Branches               225      225           
================================================
  Hits                   931      931           
  Misses                 192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Le-Caignec
Copy link
Contributor Author

fix => Commit: 1f51bf4

@Le-Caignec Le-Caignec requested a review from zguesmi July 25, 2025 17:47
@Le-Caignec Le-Caignec merged commit 59f7eaa into feature/diamond Jul 25, 2025
4 checks passed
@Le-Caignec Le-Caignec deleted the feature/rename-part-3 branch July 25, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants