Skip to content

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Jul 28, 2025

No description provided.

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.66%. Comparing base (b173aef) to head (f2a3211).
⚠️ Report is 15 commits behind head on feature/diamond.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/diamond     #240      +/-   ##
===================================================
+ Coverage            83.60%   83.66%   +0.05%     
===================================================
  Files                   38       38              
  Lines                 1214     1218       +4     
  Branches               225      227       +2     
===================================================
+ Hits                  1015     1019       +4     
  Misses                 199      199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zguesmi zguesmi self-assigned this Jul 28, 2025
@zguesmi zguesmi changed the title Apply PR reviews feat: Restore compatibility with iExec SDK. Jul 28, 2025
@zguesmi zguesmi marked this pull request as ready for review July 28, 2025 11:52
Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add TODO comments in the Registry contract to indicate that these functions should be removed ?

Base automatically changed from feature/evm-version to feature/diamond July 28, 2025 12:42
@Le-Caignec Le-Caignec self-requested a review July 28, 2025 12:44
@zguesmi
Copy link
Member Author

zguesmi commented Jul 28, 2025

Could we add TODO comments in the Registry contract to indicate that these functions should be removed ?

Done
Apply reviews

@zguesmi zguesmi merged commit 3b43823 into feature/diamond Jul 28, 2025
4 checks passed
@zguesmi zguesmi deleted the feature/pr-reviews branch July 28, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants