feat: Set owner at deployment #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deploy/0_deploy.ts
Outdated
| `Ownership of contract ${contractAddress} transferred from ${currentOwner} to ${ownerAddress}`, | ||
| ); | ||
| } | ||
| } |
deploy/0_deploy.ts
Outdated
| /** | ||
| * Deploy proxy and facets. | ||
| */ | ||
| // TODO put inside init() function. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to set a custom owner address during contract deployment by introducing an optional owner field in the chain configuration and updating the deployment script to use this configured owner instead of defaulting to the deployer address.
- Adds an optional
ownerfield to theChainConfigtype - Updates deployment script to distinguish between deployer and final owner addresses
- Implements ownership transfer functionality for all deployed contracts
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| utils/config.ts | Adds optional owner field to ChainConfig type |
| deploy/0_deploy.ts | Refactors deployment to use configured owner and implements ownership transfer |
| config/config.json | Sets owner address for a specific chain configuration |
gfournieriExec
approved these changes
Jul 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #245 +/- ##
========================================
Coverage 83.66% 83.66%
========================================
Files 38 38
Lines 1218 1218
Branches 227 227
========================================
Hits 1019 1019
Misses 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Le-Caignec
reviewed
Jul 28, 2025
| .then((contract) => contract.waitForDeployment()) | ||
| .then((contract) => contract.getAddress()); | ||
| console.log(`New RLC token deployed at: ${rlcAddress}`); | ||
| await Ownable__factory.connect(rlcAddress, deployer) |
There was a problem hiding this comment.
Suggested change
| await Ownable__factory.connect(rlcAddress, deployer) | |
| await RLC__factory.connect(rlcAddress, deployer) |
more readable
This was referenced Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.