-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Track artifact files #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 83.66% 84.83% +1.17%
==========================================
Files 38 37 -1
Lines 1218 1240 +22
Branches 227 235 +8
==========================================
+ Hits 1019 1052 +33
+ Misses 199 188 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The purpose of this PR is to track artifact files generated by the Hardhat compilation process. This addition provides better visibility into the compiled contract artifacts within the repository.
Key changes include:
- Addition of Hardhat-generated JSON artifact files for various contract interfaces and facets
- Each artifact file contains contract metadata including ABI, bytecode, and compilation information
- Files follow the standard Hardhat artifact format with
_format: "hh-sol-artifact-1"
Reviewed Changes
Copilot reviewed 48 out of 256 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
IexecPocoAccessors.json | Artifact for contract accessors interface with comprehensive ABI definitions |
IexecPoco2.v8.sol/IexecPoco2.json | Artifact for v8 version of IexecPoco2 interface with task management functions |
IexecPoco2.sol/IexecPoco2.json | Standard IexecPoco2 interface artifact |
IexecPoco1.v8.sol/IexecPoco1.json | Artifact for v8 version of IexecPoco1 interface with order matching capabilities |
IexecPoco1.sol/IexecPoco1.json | Standard IexecPoco1 interface artifact |
IexecOrderManagement.v8.sol/IexecOrderManagement.json | Artifact for v8 order management interface |
IexecOrderManagement.sol/IexecOrderManagement.json | Standard order management interface artifact |
IexecEscrowTokenSwap.json | Artifact for token swap escrow interface |
IexecEscrowToken.json | Artifact for token escrow interface |
IexecEscrowNative.json | Artifact for native currency escrow interface |
IexecERC20Common.json | Artifact for common ERC20 functionality interface |
IexecERC20.json | Artifact for ERC20 token interface |
IexecConfigurationExtra.json | Artifact for extended configuration interface |
IexecConfiguration.json | Artifact for core configuration interface |
IexecCategoryManager.json | Artifact for category management interface |
IexecAccessorsABILegacy.json | Artifact for legacy ABI accessor interface |
IexecAccessors.json | Artifact for main accessor interface |
IOwnable.json | Artifact for ownership interface |
SignatureVerifier.v8.sol/SignatureVerifier.json | Artifact for v8 signature verifier facet |
SignatureVerifier.sol/SignatureVerifier.json | Artifact for signature verifier facet |
IexecRelayFacet.json | Artifact for relay functionality facet |
IexecPocoCommon.json | Artifact for common Poco functionality facet |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
], | ||
"__filesComment": "!!! Update .gitignore if this is updated", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the goal of that ?
"!/artifacts/contracts/tools/diagrams/**/*", | ||
"!/artifacts/contracts/**/*.dbg.json", | ||
"/contracts", | ||
"!/contracts/tools/testing/**/*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to publish diagrams folder & Timelock as it's not used today for arbitrum ?
Discarded in favor of #272 |
No description provided.