Skip to content

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Jul 25, 2024

No description provided.

@zguesmi zguesmi self-assigned this Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.00%. Comparing base (d32703e) to head (ac3f9a0).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #96      +/-   ##
===========================================
+ Coverage    81.52%   83.00%   +1.48%     
===========================================
  Files           34       34              
  Lines         1077     1077              
  Branches       222      222              
===========================================
+ Hits           878      894      +16     
+ Misses         199      183      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zguesmi zguesmi marked this pull request as ready for review July 25, 2024 16:07

describe('Config', function () {
it('token', async function () {
expect(await iexecPocoAsAnyone.token()).to.equal(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add native check ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a TODO for that.
Add todo

zguesmi and others added 4 commits July 26, 2024 15:02
Co-authored-by: Jérémy James Toussaint <33313130+jeremyjams@users.noreply.github.com>
Co-authored-by: Jérémy James Toussaint <33313130+jeremyjams@users.noreply.github.com>
zguesmi and others added 2 commits July 26, 2024 16:35
Co-authored-by: Jérémy James Toussaint <33313130+jeremyjams@users.noreply.github.com>
@zguesmi zguesmi requested a review from james-toussaint July 26, 2024 14:38
Copy link
Contributor

@james-toussaint james-toussaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thanks!

@zguesmi zguesmi merged commit e675764 into develop Jul 26, 2024
@zguesmi zguesmi deleted the feature/test-migration-1 branch July 26, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants