-
Notifications
You must be signed in to change notification settings - Fork 1
feat: migrate to Scone prod #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🐳 Hadolint Dockerfile Lint ResultsClick to expand detailed resultsapi/Dockerfile:4 DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the iapp from Scone debug mode to Scone production mode, updating both the CLI and API to use production workerpools and enabling production-mode sconification with proper signing key management.
- Switches CLI to use production workerpools instead of debug workerpools
- Adds
sconeProd
boolean option to API for production sconification with signing key mounting - Updates deployment infrastructure to check for required configuration files and mount signing keys
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
cli/src/utils/sconify.ts | Adds sconeProd: true to API requests for production mode |
cli/src/utils/iexec.ts | Removes SMS debug URL parameter and renames function |
cli/src/config/config.ts | Updates workerpool addresses from debug to production endpoints |
cli/src/cmd/run.ts | Updates function call to use renamed getIExec |
cli/src/cmd/deploy.ts | Updates function call to use renamed getIExec |
cli/src/cmd/debug.ts | Updates function call to use renamed getIExec |
api/src/singleFunction/sconifyImage.ts | Adds production mode support with signing key mounting |
api/src/sconify/sconifyBuild.service.ts | Adds sconeProd parameter and updates image tagging |
api/src/sconify/sconifyBuild.handler.ts | Adds sconeProd to request schema and processing |
api/src/sconify/deprecated_sconify.service.ts | Removes unused entrypoint parameter |
api/package.json | Adds signing key generation to start scripts |
api/docker-compose.yml | Mounts signing key directory as read-only |
.github/workflows/reusable-api-deploy.yml | Adds configuration file checks before deployment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8f2ea7f
to
aec7e47
Compare
aec7e47
to
8137d03
Compare
migrate iapp from Scone debug to Scone prod
changes
API:
sconeProd
boolean option to sconify in production (defaultfalse
for backward compatibility)start
script generates a new signing key insig/enclave-key.pem
if not found--command
option is no longer passed to the scone CLI (according to Scone team, this was useless)CLI:
sconeProd: true
to use sconification in prod modeCI:
tests
deployed app with successful run on prod workerpool: