Skip to content

Conversation

PierreJeanjacquot
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot commented Aug 18, 2025

migrate iapp from Scone debug to Scone prod

changes

API:

  • Added sconeProd boolean option to sconify in production (default false for backward compatibility)
  • start script generates a new signing key in sig/enclave-key.pem if not found
  • --command option is no longer passed to the scone CLI (according to Scone team, this was useless)

CLI:

⚠️ the API must be deployed before the CLI publication

  • Switched stack to use scone prod (SMS, Workerpool)
  • Updated API request with sconeProd: true to use sconification in prod mode

CI:

  • signing key mounted from host (RO) for API deployment
  • Added server configuration files check before deploying the API

tests

deployed app with successful run on prod workerpool:

@PierreJeanjacquot PierreJeanjacquot changed the title Feat/scone prod feat: migrate to Scone prod Aug 18, 2025
Copy link

github-actions bot commented Aug 18, 2025

🐳 Hadolint Dockerfile Lint Results

Click to expand detailed results
api/Dockerfile:4 DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the iapp from Scone debug mode to Scone production mode, updating both the CLI and API to use production workerpools and enabling production-mode sconification with proper signing key management.

  • Switches CLI to use production workerpools instead of debug workerpools
  • Adds sconeProd boolean option to API for production sconification with signing key mounting
  • Updates deployment infrastructure to check for required configuration files and mount signing keys

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cli/src/utils/sconify.ts Adds sconeProd: true to API requests for production mode
cli/src/utils/iexec.ts Removes SMS debug URL parameter and renames function
cli/src/config/config.ts Updates workerpool addresses from debug to production endpoints
cli/src/cmd/run.ts Updates function call to use renamed getIExec
cli/src/cmd/deploy.ts Updates function call to use renamed getIExec
cli/src/cmd/debug.ts Updates function call to use renamed getIExec
api/src/singleFunction/sconifyImage.ts Adds production mode support with signing key mounting
api/src/sconify/sconifyBuild.service.ts Adds sconeProd parameter and updates image tagging
api/src/sconify/sconifyBuild.handler.ts Adds sconeProd to request schema and processing
api/src/sconify/deprecated_sconify.service.ts Removes unused entrypoint parameter
api/package.json Adds signing key generation to start scripts
api/docker-compose.yml Mounts signing key directory as read-only
.github/workflows/reusable-api-deploy.yml Adds configuration file checks before deployment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@PierreJeanjacquot PierreJeanjacquot marked this pull request as ready for review August 19, 2025 12:56
Copy link
Contributor

@abbesBenayache abbesBenayache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PierreJeanjacquot PierreJeanjacquot merged commit e4b6277 into main Aug 20, 2025
6 checks passed
@PierreJeanjacquot PierreJeanjacquot deleted the feat/scone-prod branch August 20, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants