Skip to content

feat: remove RLC balance check blocking deployment and add warning instead #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat: remove RLC balance check blocking deployment and add warning instead #232

wants to merge 2 commits into from

Conversation

abbesBenayache
Copy link
Contributor

…stead

PierreJeanjacquot
PierreJeanjacquot requested changes Aug 20, 2025
View reviewed changes
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to check that the user has native assets to pay for the transaction; the proposed implementation doesn't check it.

A better implementation may be to change ensureBalance by adding an option to only warn if RLC balance is empty

@PierreJeanjacquot PierreJeanjacquot changed the title feat: remove RLC balance check blocking deployment and add warning in… feat: remove RLC balance check blocking deployment and add warning instead Aug 21, 2025
@abbesBenayache @PierreJeanjacquot
feat: remove RLC balance check blocking deployment and add warning in…
428c9a2 
…stead
@abbesBenayache @PierreJeanjacquot
refactore: improve ensureBalances with warnOnlyRlc option for RLC bal…
72bdfd6 
…ance

- Add warnOnlyRlc parameter to ensureBalances function
- Always check native assets (required for transaction fees)
- Allow RLC balance warnings instead of blocking deployment
- Maintain strict RLC checking for app execution
- Improve error messages with better separation of concerns
- Use warnOnlyRlc: true in deploy.ts for flexible deployment
@PierreJeanjacquot PierreJeanjacquot force-pushed the feature/remove-rlc-check-deploy-add-warning branch from 77a7ad7 to 72bdfd6 Compare August 21, 2025 12:56
@PierreJeanjacquot
Copy link
Member

closed by #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PierreJeanjacquot PierreJeanjacquot Awaiting requested review from PierreJeanjacquot

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abbesBenayache @PierreJeanjacquot