Skip to content

Feature/remove broker engine usage #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 6, 2023
Merged

Feature/remove broker engine usage #87

merged 9 commits into from
Jun 6, 2023

Conversation

jbern0rd
Copy link
Contributor

@jbern0rd jbern0rd commented Jun 5, 2023

No description provided.

@jbern0rd jbern0rd self-assigned this Jun 5, 2023
@jbern0rd jbern0rd marked this pull request as ready for review June 5, 2023 13:32
mcornaton
mcornaton reviewed Jun 5, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

48.5% 48.5% Coverage
0.0% 0.0% Duplication

mcornaton
mcornaton approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@mcornaton mcornaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@james-toussaint james-toussaint merged commit 16be941 into develop Jun 6, 2023
@james-toussaint james-toussaint deleted the feature/remove-broker-engine-usage branch June 6, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewhitewizard thewhitewizard thewhitewizard approved these changes

+1 more reviewer

@mcornaton mcornaton mcornaton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jbern0rd jbern0rd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbern0rd @thewhitewizard @mcornaton @james-toussaint