Skip to content

Conversation

nabil-Tounarti
Copy link
Contributor

No description provided.

@nabil-Tounarti nabil-Tounarti requested a review from Copilot October 8, 2025 08:26
@nabil-Tounarti nabil-Tounarti self-assigned this Oct 8, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames bulk environment variables to use a consistent IEXEC_ prefix and consolidates the dataset variable handling into indexed variants. The changes standardize the naming convention and simplify the code by unifying how single and bulk datasets are accessed.

  • Renamed BULK_SIZE to IEXEC_BULK_SLICE_SIZE and consolidated BULK_DATASET_* variables into indexed IEXEC_DATASET_* variants
  • Unified dataset handling logic to use a single loop that handles both single (index 0) and bulk datasets (index 1+)
  • Updated all references, tests, and documentation to reflect the new naming convention

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pre-compute/src/compute/utils/env_utils.rs Updated enum variants and environment variable name mapping to use IEXEC_ prefix and indexed dataset variables
pre-compute/src/compute/pre_compute_args.rs Consolidated dataset loading logic, renamed field from bulk_size to iexec_bulk_slice_size, updated documentation and tests
pre-compute/src/compute/pre_compute_app.rs Updated test to use new field name iexec_bulk_slice_size

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nabil-Tounarti nabil-Tounarti merged commit 94c91a5 into main Oct 9, 2025
7 checks passed
@nabil-Tounarti nabil-Tounarti deleted the feature/bulk-env-rename branch October 9, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants