Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caching of dT value from pt1FilterApply4 #614

Merged
merged 1 commit into from
Sep 18, 2016

Conversation

digitalentity
Copy link
Member

Fixes #611

@digitalentity digitalentity added this to the 1.3 milestone Sep 18, 2016
@stronnag
Copy link
Collaborator

stronnag commented Sep 18, 2016

deleted ... wrong issue

@DzikuVx
Copy link
Member

DzikuVx commented Sep 19, 2016

@digitalentity is it possible that this caching of dT was also affecting D-term filtering in PID rate controller?

@digitalentity
Copy link
Member Author

Yes, I believe it's likely.
Probably the dT for the first very first PID loop is very big since it's
probably measured since zero (power-up) and accounts for all boot up
sequence.

On Mon, Sep 19, 2016 at 4:46 PM, Paweł Spychalski notifications@github.com
wrote:

@digitalentity https://github.com/digitalentity is it possible that
this caching of dT was also affecting D-term filtering in PID rate
controller?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#614 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKi_m8gotmY1xCH1zXfXNrA0SEEWTDUzks5qrpJHgaJpZM4J_8lY
.

@DzikuVx
Copy link
Member

DzikuVx commented Sep 19, 2016

That would somehow explain very big D-Term oscillations I've observed on yesterday logs. Maybe like they are not really 30Hz oscillations but an effect of aliasing (low recording speed)

@digitalentity digitalentity deleted the pt1-filter-change branch October 2, 2016 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants