Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(big) multipolygon does not seem to be displayed correctly #688

Closed
ilokhat opened this issue Mar 8, 2018 · 4 comments · Fixed by #691
Closed

(big) multipolygon does not seem to be displayed correctly #688

ilokhat opened this issue Mar 8, 2018 · 4 comments · Fixed by #691
Labels
bug 🐛

Comments

@ilokhat
Copy link

ilokhat commented Mar 8, 2018

A big multipolygon is not rendered correctly.

It is originally served from a wfs from geoserver, but I'm providing a geojson file of the multipolygon.
multipolygon.zip

It is correctly displayed in Qgis as shown in the screen captures below
itowns
multipolygon_itowns

Qgis
multipolygon_qgis

Environment

  • Version used: "itowns": "^2.3.0"
  • Browser Name and version: firefox 58.0.2 /chromium 64.0
  • Operating System and version (desktop or mobile): Linux Ubuntu 16.04
@autra
Copy link
Contributor

autra commented Mar 8, 2018

Thanks @ilokhat for your issue !

Yes, we don't support holes yet in geojson unfortunately. I hope we'll add this support soon :-)

@autra autra added the bug 🐛 label Mar 9, 2018
@ilokhat
Copy link
Author

ilokhat commented Mar 12, 2018

ok
nice, thanks for the answer !

@peppsac
Copy link
Contributor

peppsac commented Mar 12, 2018

Just tested and while holes are not yet handled in iTowns, the primary issue here is multipolygon drawing.
You can test this branch that displays the example geojson correctly (except the holes).

multipolygon_geojson

peppsac added a commit that referenced this issue Mar 13, 2018
@peppsac
refactor(vector): add hole support
b67fa7c 
This commits refactors Feature related code.

It introduces a documented Feature object.
GeoJSON2Feature returns either a Feature or an array of Feature (when parsing
a FeatureCollection object).

Geometry merges now only happens for multi-* geometries to simplify user
handling of individual features.

Geometry holes are now supported.

And last but not least this commit fixes the geometry merge bug from issue 688.

Fixes #688

BREAKING CHANGE: feature collection are not merged anymore
BREAKING CHANGE: GeoJSON2Feature now returns a Promise
peppsac added a commit that referenced this issue Mar 13, 2018
@peppsac
refactor(vector): add hole support
6765b29 
This commits refactors Feature related code.

It introduces a documented Feature object.
GeoJSON2Feature returns either a Feature or an array of Feature (when parsing
a FeatureCollection object).

Geometry merges now only happens for multi-* geometries to simplify user
handling of individual features.

Geometry holes are now supported.

And last but not least this commit fixes the geometry merge bug from issue 688.

Fixes #688

BREAKING CHANGE: feature collection are not merged anymore
BREAKING CHANGE: GeoJSON2Feature now returns a Promise
@peppsac peppsac mentioned this issue Mar 13, 2018
Merged
peppsac added a commit that referenced this issue Mar 13, 2018
@peppsac
refactor(vector): add hole support
db3748b 
This commits refactors Feature related code.

It introduces a documented Feature object.
GeoJSON2Feature returns either a Feature or an array of Feature (when parsing
a FeatureCollection object).

Geometry merges now only happens for multi-* geometries to simplify user
handling of individual features.

Geometry holes are now supported.

And last but not least this commit fixes the geometry merge bug from issue 688.

Fixes #688

BREAKING CHANGE: feature collection are not merged anymore
BREAKING CHANGE: GeoJSON2Feature now returns a Promise
peppsac added a commit that referenced this issue Mar 13, 2018
@peppsac
refactor(vector): add hole support
642e8a5 
This commits refactors Feature related code.

It introduces a documented Feature object.
GeoJSON2Feature returns either a Feature or an array of Feature (when parsing
a FeatureCollection object).

Geometry merges now only happens for multi-* geometries to simplify user
handling of individual features.

Geometry holes are now supported.

And last but not least this commit fixes the geometry merge bug from issue 688.

Fixes #688

BREAKING CHANGE: feature collection are not merged anymore
BREAKING CHANGE: GeoJSON2Feature now returns a Promise
@ilokhat
Copy link
Author

ilokhat commented Mar 13, 2018

nice. i will try ASAP
Thanks !

peppsac added a commit that referenced this issue Mar 26, 2018
@peppsac
refactor(vector): add hole support
9fa173f 
This commits refactors Feature related code.

It introduces a documented Feature object.
GeoJSON2Feature returns either a Feature or an array of Feature (when parsing
a FeatureCollection object).

Geometry merges now only happens for multi-* geometries to simplify user
handling of individual features.

Geometry holes are now supported.

And last but not least this commit fixes the geometry merge bug from issue 688.

Fixes #688

BREAKING CHANGE: feature collection are not merged anymore
BREAKING CHANGE: GeoJSON2Feature now returns a Promise
peppsac added a commit that referenced this issue Mar 26, 2018
@peppsac
refactor(vector): add hole support
a212dde 
This commits refactors Feature related code.

It introduces a documented Feature object.
GeoJSON2Feature returns either a Feature or an array of Feature (when parsing
a FeatureCollection object).

Geometry merges now only happens for multi-* geometries to simplify user
handling of individual features.

Geometry holes are now supported.

And last but not least this commit fixes the geometry merge bug from issue 688.

Fixes #688

BREAKING CHANGE: feature collection are not merged anymore
BREAKING CHANGE: GeoJSON2Feature now returns a Promise
@peppsac peppsac mentioned this issue Jun 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(vector): rework feature support iTowns/itowns
3 participants
@autra @peppsac @ilokhat