Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Requirements] Update web browsers requirements for iTowns #2252

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

Desplandis
Copy link
Contributor

@Desplandis Desplandis commented Jan 8, 2024

Description

This PR updates and formalizes the web browser requirements for iTowns.
See proposal #2256.

Motivation and Context

We are currently using babel's preset-env plugin to decide which syntax transforms and polyfills are used during the transpilation step. However, we do not set an output target in its configuration which causes

Babel [to] assume you are targeting the oldest browsers possible [...] @babel/preset-env will transform all ES2015-ES2020 code to be ES5 compatible.
Source

This PR aims to:

  • formalize which browsers and versions are supported by iTowns (defaults target as decided by the linked proposal which supports webgl2).
  • reduce the transpiled code size by supporting more recent browsers

Removing unnecessary polyfills for modules well-supported by our target is the object of the follow-up PR #2248

BREAKING CHANGE: iTowns now officially supports only the two last
versions + versions with >0.5% market share of popular browsers as
well as the lastest version of Firefox ESR. WebGL2.0 support is also
mandatory.
@Desplandis Desplandis marked this pull request as ready for review January 24, 2024 21:17
@jailln jailln self-assigned this Feb 1, 2024
@jailln jailln self-requested a review February 1, 2024 15:58
@Desplandis Desplandis merged commit f31fec9 into iTowns:master Feb 5, 2024
9 checks passed
@Desplandis Desplandis deleted the babel/update-targets branch February 5, 2024 15:18
@Desplandis Desplandis mentioned this pull request Mar 21, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants