ESM distribution #2296
Merged
ESM distribution #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desplandis
changed the title
Desplandis
force-pushed
the
migrate/esm
branch
3 times, most recently
from
0f7b8eb
to
9bc5763
Compare
This includes: - all scripts under the docs repository (publish.js is loaded with require()) - all eslintrc config scripts (loaded with require()) - grunt/bump script (loaded with require()) - conventional changelog script (loaded with require()) - webpack.config
BREAKING CHANGE: The itowns library drops the CommonJS distribution in favor of a standard ECMAScript module (ESM) distribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up of #2256, this PR drops the
CJS(CommonJS modules) distribution is favor of a standardESM(ECMAScript) distribution.Fixes #2256
Motivation and Context
#2252 bumped the web browser requirements. This guarantees that we now only support ESM-compatible browsers. Moreover,
three.jsis currently migrating to a pureESMpackage.TODOs
type: modulefield to thepackage.jsonwebpackconfig file.eslintconfig files (loaded withrequire(), shall be .cjs)nyc, change toc8). Change coverage tool from nyc to c8 #2299babel.publish.jsis loaded withrequire()and shall be commonJS).preparescript (already.mjs)replacescript (already.mjs)changelogscript (loaded withrequire(), shall be.cjs)bumpscript (loaded withrequire(), shall be.cjs)