Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBML connection problem #740

Closed
ugurdogrusoz opened this issue Jul 23, 2024 · 6 comments
Closed

SBML connection problem #740

ugurdogrusoz opened this issue Jul 23, 2024 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ugurdogrusoz
Copy link
Contributor

In case we have a protein, process and AND node, if we first connect AND to process via a catalysis edge, then we cannot connect protein to process via a consumption edge. However, if we first connect protein to process via a consumption edge, then we can connect AND to process via a catalysis edge. We should be able to connect consumption edge in the first case as well.

@ugurdogrusoz ugurdogrusoz added the bug Something isn't working label Jul 23, 2024
@ugurdogrusoz ugurdogrusoz added this to the version 4.0 milestone Jul 23, 2024
@umut-er
Copy link
Contributor

umut-er commented Jul 24, 2024

There is a more general issue of sbml processes not being allowed to take in multiple inputs or multiple outputs (except association / dissociation, those are allowed to give out only 1 output but can take unlimited inputs). This is probably relevant to this issue.

@ugurdogrusoz
Copy link
Contributor Author

There is a more general issue of sbml processes not being allowed to take in multiple inputs or multiple outputs (except association / dissociation, those are allowed to give out only 1 output but can take unlimited inputs). This is probably relevant to this issue.

Associations take 2 or more inputs and output 1. Dissociations do the reverse and take only 1 input, producing at least. Constructing a compound molecule (i.e. a complex) vs. decomposing it back.

From what I can tell dissociation works fine. Associations can also take multiple inputs but no output can be constructed.

All other process node types seem to have problems taking multiple inputs or outputs, except truncated processes which can produce multiple outputs.

So, things are pretty random / messed up for some reason.

@umut-er
Copy link
Contributor

umut-er commented Jul 25, 2024

@ugurdogrusoz This behavior you described above was also implemented into the export functionality. I changed those so that we can have the wanted behavior as part of #712.

@ugurdogrusoz
Copy link
Contributor Author

@umut-er Do you mean this issue is part of #712 (redundant) and can be closed? If so, please close it.

@umut-er
Copy link
Contributor

umut-er commented Aug 1, 2024

@ugurdogrusoz No, I am not saying that. I am saying that the export functionality was made with this in mind. It is now changed though. When this issue is fixed, we won't have to change the export (most likely). That's what I am saying.

@ugurdogrusoz
Copy link
Contributor Author

ugurdogrusoz commented Aug 18, 2024

Original problem with protein, process and AND node connections are fixed but:

  • we have problems with the rules on what can connect to what
  • we have problems that a process cannot produce multiple species (>1 output)
    Check to make sure all rules in tables on pages 12-16 of this document are satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants