Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to fcose layout style and use packing #251

Closed
ugurdogrusoz opened this issue Jun 21, 2021 · 3 comments
Closed

Switch to fcose layout style and use packing #251

ugurdogrusoz opened this issue Jun 21, 2021 · 3 comments
Assignees
@ugurdogrusoz @hasanbalci @msalihaltun
Labels
enhancement Enhancement to existing feature
Milestone
2.2

Comments

@ugurdogrusoz
Copy link
Contributor

We shoud use fcose layout instead of cose-bilkent. We should also enable component packing from layout-utilities extension for both regular and incremental layout.
@ugurdogrusoz ugurdogrusoz added the enhancement Enhancement to existing feature label Jun 21, 2021
@ugurdogrusoz ugurdogrusoz added this to the 2.2 milestone Jun 21, 2021
msalihaltun added a commit that referenced this issue Jun 21, 2021
@msalihaltun
Switch layout to fcose #251
7ad6d8f
@ugurdogrusoz
Copy link
Contributor Author

ugurdogrusoz commented Jun 21, 2021 •
edited

Something wrong with layout. To reproduce, load the following (contains an edge from a child to an ancestor):
KIRC-2013-RTK-RAS-PI(3)K-pathway.txt

Resulting layout (see the node-node overlaps in the component on the right):
KIRC-2013-RTK-RAS-PI(3)K-pathway

Related to iVis-at-Bilkent/cytoscape.js-fcose#43?

@ugurdogrusoz ugurdogrusoz mentioned this issue Jun 21, 2021
Closed
@hasanbalci
Copy link
Contributor

@msalihaltun @ugurdogrusoz Probably, rebuild of PM will solve this issue, because I made a one last commit to layout-base for edges connected to ancestor.

@msalihaltun
Copy link
Contributor

Updating lock file & rebuild solves it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ugurdogrusoz ugurdogrusoz

@hasanbalci hasanbalci

@msalihaltun msalihaltun

Labels
enhancement Enhancement to existing feature
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
3 participants
@ugurdogrusoz @hasanbalci @msalihaltun