-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: OmniSciDB - Enable logical value tests #2084
TST: OmniSciDB - Enable logical value tests #2084
Conversation
@xmnlab what do you think about changing omnisci image in |
@anmyachev from a dev's perspective I think it is a good idea .. but from a user's perspective not sure if it could have side effects. |
@xmnlab and I just chatted about using the latest in the docker compose and I think it does make sense because there aren't currently (AFAIK) a large number of downstream ibis users who are need support for older omnisci versions. I think once that does become the case, we should make sure to document which versions of the server we support and test on those. |
@jreback what are your thoughts about this? |
this is probably fine |
sounds good. thanks! |
ad3ccef
to
85ef796
Compare
it is done for review! thanks! |
LGTM. @jreback what do you think about? |
@jreback a gentle remind about this PR :) |
85ef796
to
e1df947
Compare
depends on #2104 |
e1df947
to
858f5a1
Compare
858f5a1
to
1a3b45a
Compare
suggestions applied, ci green |
a03db28
to
eee0f65
Compare
thanks for the review @jreback ! ci is green :) |
thanks |
Enable tests that use queries without table and another tests that are already working on OmniSciDB