Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Pre-Split Naming #10088

Closed
friedmud opened this issue Oct 15, 2017 · 6 comments
Closed

Better Pre-Split Naming #10088

friedmud opened this issue Oct 15, 2017 · 6 comments
Labels
C: Framework C: libMesh P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@friedmud
Copy link
Contributor

Rationale

All of the rationale (and code changes) are over here: libMesh/libmesh#1455

The idea is change the naming scheme for pre-split checkpoint files to make them easier to deal with

Impact

Will change the naming scheme in a backwards incompatible way so a warning will need to go to users.

@friedmud friedmud added C: libMesh C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Oct 15, 2017
friedmud added a commit to friedmud/moose that referenced this issue Oct 15, 2017
@permcody
Copy link
Member

Please don't mess with the template, even if you dislike it. The three sections are required by the NQA-1 process. I'm for your requested change here though.

@friedmud
Copy link
Contributor Author

friedmud commented Oct 19, 2017 via email

@permcody
Copy link
Member

permcody commented Oct 19, 2017 via email

@andrsd
Copy link
Contributor

andrsd commented Oct 19, 2017

In GitLab, you can actually have several different templates for filling in issues. I made one for bugs and a different one for enhancements (in RELAP-7). github needs to copy that :-)

@permcody
Copy link
Member

permcody commented Oct 19, 2017 via email

friedmud added a commit to friedmud/moose that referenced this issue May 6, 2018
friedmud added a commit to friedmud/moose that referenced this issue Jun 20, 2018
@permcody
Copy link
Member

permcody commented Jul 2, 2018

This was addressed with changes in libMesh and #10623.

@permcody permcody closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework C: libMesh P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

3 participants