Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saline submodule instructions don't work #27015

Closed
travismui opened this issue Mar 7, 2024 · 1 comment
Closed

Saline submodule instructions don't work #27015

travismui opened this issue Mar 7, 2024 · 1 comment
Assignees
@travismui
Labels
C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@travismui
Copy link
Contributor

travismui commented Mar 7, 2024 •
edited
Loading

Bug Description

The current instructions listed on the SalineMoltenSaltFluidProperties documentation page is missing the --checkout flag which is needed as the current update strategy is "none". I believe the submodule name is also incorrect if you're initializing from the head of the Moose repo.
Current instructions:

git submodule update --init contrib/saline

Proposed fix:

git submodule update --init --checkout modules/fluid_properties/contrib/saline

Steps to Reproduce

Try the instructions on a local build, it should report that either that contrib/saline does not match any known submodule, or that modules/fluid_properties/contrib/saline was skipped.

Impact

Confusion for users

[Optional] Diagnostics

No response
@travismui travismui added P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations. labels Mar 7, 2024
travismui added a commit to travismui/moose that referenced this issue Mar 7, 2024
@travismui
Fix submodule update instruction for saline, refs idaholab#27015
7434372
@travismui travismui mentioned this issue Mar 7, 2024
Merged
@lindsayad lindsayad added the C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module label Mar 7, 2024
@travismui
Copy link
Contributor Author

Closed by #27016

schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this issue Mar 12, 2024
@travismui @schakrabortygithub
Fix submodule update instruction for saline, refs idaholab#27015
6c4441b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travismui travismui

Labels
C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lindsayad @travismui