Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submodule update instruction for saline #27016

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

travismui
Copy link
Contributor

Reason

Instructions to build Saline on the SalineMoltenSaltFluidProperties doc page is not working, fix this to help out new users. Refs #27015.

Design

  • Add --checkout flag to the doc instructions given the current git update strategy
  • Update some mentions of contrib/saline to the moose submodule name modules/fluid_properties/contrib/saline to reduce user confusion

Impact

Hopefully make it easier for first-adoption of Saline in Moose.

@travismui travismui marked this pull request as draft March 7, 2024 15:27
@GiudGiud GiudGiud self-assigned this Mar 7, 2024
@travismui travismui marked this pull request as ready for review March 7, 2024 16:52
@travismui travismui requested a review from permcody as a code owner March 7, 2024 16:52
@moosebuild
Copy link
Contributor

Job Documentation on cfcc4a8 wanted to post the following:

View the site here

This comment will be updated on new commits.

@lindsayad lindsayad added the C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module label Mar 7, 2024
@moosebuild
Copy link
Contributor

Job Modules parallel on cfcc4a8 : invalidated by @travismui

Convergence failures on some MMC and a diff on mixture Rayleigh-Benard tests for Navier Stokes distributed/threaded stages, should be unrelated to these changes. Invalidate and re-run.

@moosebuild
Copy link
Contributor

Job Coverage on cfcc4a8 wanted to post the following:

Framework coverage

b606ff #27016 cfcc4a
Total Total +/- New
Rate 85.29% 85.19% -0.09% -
Hits 100941 100829 -112 0
Misses 17410 17522 +112 0

Diff coverage report

Full coverage report

Modules coverage

Mutiple base shas were found when retrieving head reports:
b606ff7
1887192

Full coverage reports

Reports
  • framework
  • chemical_reactions (FAILED)
  • combined
  • contact (FAILED)
  • electromagnetics (FAILED)
  • external_petsc_solver (FAILED)
  • fluid_properties (FAILED)
  • fsi (FAILED)
  • functional_expansion_tools (FAILED)
  • geochemistry (FAILED)
  • heat_transfer (FAILED)
  • level_set (FAILED)
  • misc (FAILED)
  • navier_stokes (FAILED)
  • optimization (FAILED)
  • peridynamics (FAILED)
  • phase_field (FAILED)
  • porous_flow (FAILED)
  • ray_tracing (FAILED)
  • rdg (FAILED)
  • reactor (FAILED)
  • richards
  • scalar_transport (FAILED)
  • solid_mechanics (FAILED)
  • solid_properties (FAILED)
  • stochastic_tools (FAILED)
  • thermal_hydraulics (FAILED)
  • xfem (FAILED)

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage on cfcc4a8 wanted to post the following:

The following coverage requirement(s) failed:

  • Failed to generate chemical_reactions coverage rate (required: 92.0%)
  • Failed to generate contact coverage rate (required: 87.0%)
  • Failed to generate electromagnetics coverage rate (required: 94.0%)
  • Failed to generate external_petsc_solver coverage rate (required: 85.0%)
  • Failed to generate fluid_properties coverage rate (required: 84.0%)
  • Failed to generate fsi coverage rate (required: 85.0%)
  • Failed to generate functional_expansion_tools coverage rate (required: 81.0%)
  • Failed to generate geochemistry coverage rate (required: 96.0%)
  • Failed to generate heat_transfer coverage rate (required: 87.0%)
  • Failed to generate level_set coverage rate (required: 85.0%)
  • Failed to generate misc coverage rate (required: 32.0%)
  • Failed to generate navier_stokes coverage rate (required: 77.0%)
  • Failed to generate optimization coverage rate (required: 86.0%)
  • Failed to generate peridynamics coverage rate (required: 77.0%)
  • Failed to generate phase_field coverage rate (required: 85.0%)
  • Failed to generate porous_flow coverage rate (required: 95.0%)
  • Failed to generate ray_tracing coverage rate (required: 93.0%)
  • Failed to generate rdg coverage rate (required: 63.0%)
  • Failed to generate reactor coverage rate (required: 90.0%)
  • Failed to generate scalar_transport coverage rate (required: 85.0%)
  • Failed to generate solid_mechanics coverage rate (required: 84.0%)
  • Failed to generate solid_properties coverage rate (required: 83.0%)
  • Failed to generate stochastic_tools coverage rate (required: 88.0%)
  • Failed to generate thermal_hydraulics coverage rate (required: 89.0%)
  • Failed to generate xfem coverage rate (required: 80.0%)

@GiudGiud GiudGiud merged commit d9f4aef into idaholab:next Mar 8, 2024
46 of 47 checks passed
@travismui travismui deleted the PR_saline_submodule_doc branch March 8, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants