Fix recover and pedantic behavior #13579
Conversation
|
A little rushed in the end. But this seems to be working. |
| exit_code = status.race.code | ||
|
|
||
| else: | ||
| print("There are no race conditions.") |
There was a problem hiding this comment.
woops. This got deleted by accident
python/TestHarness/JobDAG.py
Outdated
| self._doMakeSerializeDependencies() | ||
| for job in self.__job_dag.topological_sort(): | ||
| job.addDownsteamNodes(self.__job_dag.all_downstreams(job)) | ||
| job.addUpsteamNodes(self.__job_dag.predecessors(job)) |
There was a problem hiding this comment.
I am not sure this is necessary anymore. Now that the DAG is as it was, we can, should be able to call the DAG's predecessors/all_downstreams.
|
Job Documentation on 03e210d wanted to post the following: View the site here This comment will be updated on new commits. |
python/contrib/dag/__init__.py
Outdated
| @@ -33,22 +33,6 @@ def __cacheGraph(self): | |||
| self.__cached_graph = self.clone() | |||
| return self.__cached_graph | |||
|
|
|||
| # Added by the MOOSE group | |||
There was a problem hiding this comment.
I'm going to suggest that we don't remove this method. I'm still not convinced that we don't need it if we are doing things right. When I have some time, I'd like to sit down and really go through a few scenarios of the DAG. I've thought about this a lot and don't see why we don't need this method. Just leave it in for now in case we decide we'll want it later.
|
There is an issue relating to the print output when multiple race conditions exist. I'm looking into it. Please do not merge. |
|
This still doesn't work - the problem here now is that the test harness prints that it's rerunning Part1 of a two part test but it doesn't actually rerun it. This is bad because the data created in Part1 might be changing (if the developer is working on something) but since the TestHarness isn't actually doing anything now, it won't rerun Part1 so Part2 will always fail. To test:
You will note that it prints the Part1 and Part2 of the failed test, which is good, but it doesn't actually run the command. It just reports OK. I verified that current HEAD reruns the command as expected. |
|
That is sorta impossible: moose/python/TestHarness/JobDAG.py Line 141 in 6f1047a I specifically designed it not to re-run the part 1 test. If you actually want part one to execute, thats an easy fix. if status == tester.success and self._hasDownStreamsWithFailures(job):
- tester.setStatus(tester.success)
- # Do we care? I figure, we should at least mention something. This job is not actually going to re-execute an app.
- tester.addCaveats('previous results: {}'.format(status.status))
- job.setStatus(job.finished)
+ tester.addCaveats('re-running')
+ return |
milljm
force-pushed
the
recover-pedantic-13578
branch
from
500db2d
to
03e210d
Compare
Fix recover and pedantic skipped dependencies. Optimize pedantic operations. Closes idaholab#13578
Continue to reduce code necessary to perform pedantic testing Refs idaholab#13578
The following methods are no longer necessary.
When running --pedantic, and no issues found, we should say so. Re-adding serialized DAG routines. Remove un-used upstream/downstream methods. Refs idaholab#13578
File matches need to be updated, not clobbered.
When using --failed-tests and --recover, make the part 1 test actually re-execute.
|
You do realize you said exactly opposite things, right? I'm going to go with the "easy fix" not "sorta impossible" comment |
Fix recover and pedantic skipped dependencies.
Optimize pedantic operations.
Closes #13578