Adding in optional linking and compiler defines for libPNG #13654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tag @Hysrok |
|
Job Documentation on c73adae wanted to post the following: View the site here This comment will be updated on new commits. |
|
Shouldn’t this be done as a configure test in libMesh? |
It should be part of configure, yes. However, since we aren't using it in libMesh there's an argument to be made that it probably doesn't belong there. This little Makefile hack should work fine. Cue the MOOSE configure discussion... |
|
Incorporated into #13646. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #12846
Linking in libpng when it exists in support of an upcoming PR #13646.