Fixing up PNGOutputter issues #13753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
permcody
commented
Jul 17, 2019
| @@ -280,7 +279,7 @@ PNGOutput::makePNG() | |||
| Real width = dist_x * _resolution; | |||
| Real height = dist_y * _resolution; | |||
| // Allocate resources. | |||
| std::vector<png_byte> row((width * 4) + 1); | |||
| std::vector<png_byte> row((width + 1) * 4); | |||
There was a problem hiding this comment.
Cause of running out of bounds...
permcody
commented
Jul 17, 2019
| @@ -348,7 +347,7 @@ PNGOutput::makePNG() | |||
| if (infop != nullptr) | |||
| png_free_data(pngp, infop, PNG_FREE_ALL, -1); | |||
| if (pngp != nullptr) | |||
| png_destroy_write_struct(&pngp, (png_infopp) nullptr); | |||
| png_destroy_write_struct(&pngp, &infop); | |||
There was a problem hiding this comment.
Leaking the info struct...
|
FYI @Hysrok - This commit fixes up a few issues with the outputted that is preventing it from getting merged into the devel branch. Let me know if you have any questions. There were two memory issues. |
- PNGOutputter restricted to work in dynaimc linkage mode only due to unresolved linkage problem with the library in static mode - Some constness added to member variables - Memory issue fixed refs idaholab#13646
rwcarlsen
approved these changes
Jul 17, 2019
|
Job Documentation on d2d9331 wanted to post the following: View the site here This comment will be updated on new commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to unresolved linkage problem with the library in static mode
refs #13646