Skip to content

Conversation

johanneshiry
Copy link
Member

@johanneshiry johanneshiry commented Apr 6, 2020

Resolves #101
Resolves #103

New features

  • Initial implementation of CsvRawGridSource
  • Initial implementation of CsvDataSource
  • Initial implementation of CsvTypeSource

Fixes + adaptions:

  • CsvFileConnector now converts camel case field names to snake case to account for database field names
  • adds a missing field in ConnectorInput in the InputDatamodelConcept.puml documentation
  • renamed field noOfParallelDevices to parallelDevices (+ adapted documentation + tests accordingly)
  • removed TimeTools from Processors as they cause a lot of trouble in several places and replaced them with default ZonedDateTime.toString() (=harmonising ZonedDateTime handling for I/O operations in processors + factories)
  • fixes a new bug in AssetInputFactoryInput introduced by Extractor for nested Models into their own collections for persistence  #78
  • fixes a bug in EntityProcessor that lead to processing of the internal node of a three winding transformer + adapted tests accordingly
  • fixes a bug in EntityProcessor that processed parallel devices in SwitchInput (which defaults to 1 and has no constructor field -> should not be written out) + adapted tests accordingly
  • adapted DataSink interface -> removed getConnector() + added shutdown() and persistSubGrid()
  • added electric vehicles to SystemParticipants class
  • added method to DataSink to persist a JointGrid directly
  • added method in ValidationUtils to determine if a collection of UniqueEntity elements contains distinct uuids or not + corresponding test

…d-source

# Conflicts:
#	src/main/java/edu/ie3/datamodel/io/connectors/CsvFileConnector.java
…nsform them back to camelcase again during fieldsToAttributes map creation
…/O operations

- changed InputDatamodelConcept.puml noOfParallelDevices -> parallelDevices
- adapted tests accordingly to noOfParallelDevices changes
- removed TimeTools for writing data in processors and replaced them with plain ZDT String as we don't use them in factories (= harmonising ZonedDateTimeHandling for I/O operations)
- fixed a newly introduced bug in AssetInputEntityFactory with operator field
…put which defaults to 1 and hence should not be written out + adapted test accordingly
@johanneshiry johanneshiry added bug Something isn't working enhancement New feature or request labels Apr 6, 2020
@johanneshiry johanneshiry added this to the Version 1.0 milestone Apr 6, 2020
@johanneshiry johanneshiry self-assigned this Apr 6, 2020
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #102   +/-   ##
=========================================
  Coverage     71.35%   71.35%           
  Complexity     1264     1264           
=========================================
  Files           198      198           
  Lines          4856     4856           
  Branches        537      537           
=========================================
  Hits           3465     3465           
  Misses         1090     1090           
  Partials        301      301           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd1682...7fd1682. Read the comment docs.

sensarmad and others added 27 commits April 16, 2020 12:59
- minor changes in GraphicSource and CsvGraphicSource
…ource

- adapted javadoc in RawGridSource and CsvRawGridSource
…rInputEntityData.java

Co-Authored-By: Chris Kittl <44838605+ckittl@users.noreply.github.com>
…est.groovy

Co-Authored-By: Chris Kittl <44838605+ckittl@users.noreply.github.com>
…est.groovy

Co-Authored-By: Chris Kittl <44838605+ckittl@users.noreply.github.com>
…est.groovy

Co-Authored-By: Chris Kittl <44838605+ckittl@users.noreply.github.com>
…est.groovy

Co-Authored-By: Chris Kittl <44838605+ckittl@users.noreply.github.com>
…ceTest.groovy

Co-Authored-By: Chris Kittl <44838605+ckittl@users.noreply.github.com>
…e/PowerSystemDatamodel into jh/#101-csv-raw-grid-source
@ckittl ckittl merged commit 310acd3 into master Apr 16, 2020
@ckittl ckittl deleted the jh/#101-csv-raw-grid-source branch April 16, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uuid uniqueness check when building SubGridContainers & JointGridContainer Implement CsvRawGridSource
3 participants