-
Notifications
You must be signed in to change notification settings - Fork 7
Implementation of sources for csv files + several bugfixes #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
195 commits
Select commit
Hold shift + click to select a range
237d17b
merge in feature branch jh/#96-operator-input-factory
johanneshiry 1486499
initial implementation of CsvRawGridSource
johanneshiry f246984
Merge branch 'jh/#78-nested-model-extractor' into jh/#101-csv-raw-gri…
johanneshiry c11609d
extending CsvDataSource to account for snake from input files and tra…
johanneshiry 4df9b29
added missing field for ConnectorInput in InputDatamodelConcept.puml
johanneshiry 4b42c3b
- changed field noOfParallelDevices -> parallelDevices to harmonize I…
johanneshiry 73cf856
- CsvRawGridSource processing for lines, nodes and transformer2ws
johanneshiry 3360934
fix a bug in EntityProcessor that leads to processing internal node o…
johanneshiry 68d64b6
3 winding transformers processing from csv files
johanneshiry 7051389
fix a bug in EntityProcess that processed parallelDevices in SwitchIn…
johanneshiry 0029643
finished CsvRawGridSource for all grid entities + fmt
johanneshiry 061d9a4
Merge branch 'master' into jh/#101-csv-raw-grid-source
johanneshiry 91ce990
added shutdown() in DataSink
johanneshiry 8779db4
added evs to SystemParticipants class
johanneshiry a008dfd
added method to DataSink to persist a JointGrid directly
johanneshiry 714191c
cleanup in CsvRawGridSource
johanneshiry 41a896d
added method in ContainerUtils to determine if a collection of Unique…
johanneshiry 8f611ab
moved unique entity testing method into ValidationUtils + added valid…
johanneshiry c3869f6
improved exception message for easier debugging for duplicate uuids i…
johanneshiry c854da9
fix GridTestData + dependant tests to enforce new unique uuid policy
johanneshiry 22cb039
added unique uuids to SystemParticipantTestData for all entities
johanneshiry 1787836
- fix default Lat/Long in NodeInput
johanneshiry ea51c4c
performance improved CsvRawGridSource getNodes()
johanneshiry 3bc2757
added regex to perform valid splitting with geoJson strings as values…
johanneshiry aa5af28
removed travis.yml
johanneshiry f47a47d
improvements in CsvRawGridSource
johanneshiry bf66dc4
fmt
johanneshiry d1250f3
Merge remote-tracking branch 'remotes/origin/master' into jh/#101-csv…
johanneshiry 8fae82f
fix a bug with wrong field name in SystemParticipantTypeInputFactory …
johanneshiry 24da53a
replaced method based fieldToAttributesMapping in CsvRawGridSource by…
johanneshiry a228d7b
deleted old method due to redudancy in CsvDataSource + adapted CsvTyp…
johanneshiry 6b9732b
removed unnecessary collect operations in CsvRawGridSource + replaced…
johanneshiry 578a259
improved error logging in EntityFactory
johanneshiry e60514a
added interface for thermal sources
johanneshiry 27e4ea4
extended SystemParticipantSource
johanneshiry 8910ab4
fix cosphirated bugs in PvInputFactory and LoadInputFactory + improve…
johanneshiry 1627f67
initial implementation of CsvSystemParticipantSource
johanneshiry 06128ec
moved CsvFileConnector from child classes to abstract super class Csv…
johanneshiry 7e72c72
- ThermalBus + ThermalStorage support for Extractor
johanneshiry 2077288
ThermalSource interface + CsvThermalSource implementation
johanneshiry 26fffa6
removed code duplicates in CsvRawGridSource + simplified buildAssetIn…
johanneshiry 793d399
simplified AssetInputEntityData and replaced Optional<OperatorInput> …
johanneshiry 2ece933
added thermal source to documentation + let ThermalSource extend Data…
johanneshiry db96b48
performance improvements + code cleanup in CsvSystemParticipantSource
johanneshiry 8ea2337
removed MeasurementUnitInputEntityData + replaced it with UntypedSing…
johanneshiry d13228e
replaced LineInputEntityData + Transformer2WInputEntityData with Type…
johanneshiry 4665e35
adapted Transformer3WInputEntityData inheritance to apply to the new …
johanneshiry 00cce81
cleanup + improvements in CsvRawGridSource + CsvSystemParticipantSource
johanneshiry ddf16b2
Merge branch 'master' into jh/#101-csv-raw-grid-source
johanneshiry 66cb046
fix the tests based on the new changes and improvements
johanneshiry ff39302
simplified version of tracking of invalid elements in CsvRawGridSource
johanneshiry 47354bf
- more code cleanup + removing of duplicates in CsvRawGridSource + Cs…
johanneshiry f500aac
method renaming for more clarity what it does
johanneshiry c23b96f
deleted FactoryProvider.java
johanneshiry 4f4de55
Merge branch 'jh/#107-graphic-input-factories-and-sources' into jh/#1…
johanneshiry 31c517a
fix a bug in Extractor when entities contain multiple nested entities
johanneshiry b4ebf20
- added GraphicSource interface
johanneshiry 7b82e16
removed unused rawGridSource from CsvThermalSource
johanneshiry 9ee0fb5
merge ck/#94 into feature branch
johanneshiry 6673553
started documentation and renamed UntypedSingleNodeEntityData to more…
johanneshiry 566a3f7
cleanup + documentation in several classes
johanneshiry e21f726
let SinkException be a normal exception instead of a RuntimeException
johanneshiry 62bdc4d
valid logging in CsvFileConnector
johanneshiry c332e1e
addressed several todos
johanneshiry 1dc1e06
improvements in CsvFileConnector to avoid overriding files (now appen…
johanneshiry 94acc10
- make Extractor ignore OperatorInput.NO_OPERATOR_ASSIGNED
johanneshiry c040ad7
added support for new characteristics in CsvDataSource
johanneshiry 835ceed
added first CsvIOTest example
johanneshiry 69a1c6a
- replaced TimeTools in GridTestData with new TimeUtil
johanneshiry 23a2ca4
replaced camelCaseToSnakeCase() in CsvFileConnector with StringUtils …
johanneshiry 164627d
- added test für CsvDataSource
johanneshiry da3768b
- initial CsvTypeSourceTest
johanneshiry d64e10a
- fixed a bug in Extractor + introduced Extractable interface to avoi…
johanneshiry 27e9288
Revert "- fixed a bug in Extractor + introduced Extractable interface…
johanneshiry 1ce64ac
- fixed a bug in Extractor + added corresponding test
johanneshiry a54b3b4
- fixed another bug in CsvDataSource
johanneshiry cd4c2ff
- equals + hashCode methods in LineGraphicInputEntityData + NodeGraph…
johanneshiry f0846a7
- fmt
johanneshiry 0ad4342
minor refactoring in CsvDataSource + fmt
johanneshiry 87c01b1
fix tests + fmt
johanneshiry e306d24
removed CsvRawGridSource vom CsvThermalSource
johanneshiry 822d43c
added missing test data files
johanneshiry 2408679
added missing test data files
johanneshiry 676a541
added dummies for CsvThermalSourceTest
johanneshiry 3082f1d
added empty files for CsvRawGridSourceTest + CsvSystemParticipantSour…
johanneshiry 5a5cf01
simplifications + removed code duplicates in CsvRawGridSource & CsvSy…
johanneshiry 381152d
added test for aggregated type extraction in CsvDataSource
johanneshiry b5a6eed
- equals() and hashCode() in SystemParticipantTypedEntityData
johanneshiry 54bd6bc
simplifications + removed code duplicates in CsvRawGridSource & CsvSy…
johanneshiry 4fdd94a
Merge branch 'master' into jh/#101-csv-raw-grid-source
johanneshiry a6062e5
Breaking down methods
ckittl c6ac5e6
Opting out non working tests
ckittl 0d5ae10
Testing the conversion of a single AssetInputEntityData to ConnectorI…
ckittl 512e34d
Testing the conversion of a Stream of AssetInputEntityData to a Strea…
ckittl 187eb31
Testing the conversion of ConnectorInputEntityData to TypedConnectorI…
ckittl 6bac364
init branch
sensarmad 9827492
Transformer 2w test
sensarmad 7f6e2a4
Transformer 3w test
sensarmad 621f0d4
operator test
sensarmad faaeb44
line type test
sensarmad 51708a2
improved stability for csv file parsing
johanneshiry df318fe
Testing the conversion of TypedConnectorInputEntityData to Transforme…
ckittl c4626d7
prevent quoting all fields in all lines in BufferedCsvWriter
johanneshiry b497050
Only quote the head line of a csv file
ckittl df9116c
fix processing of NO_OPERATOR_ASSIGNED + added corresponding test
johanneshiry 8444340
Correct handling of default no operator
ckittl 5b90ce4
system participant tests (wec fails due to cpCharacteristic)
sensarmad 486b18d
expand transformer 2w test
sensarmad 756293f
expand operator test
sensarmad bda3376
expand line type test
sensarmad 3a1f06f
Adapting the equals and hash code methods for characteristics
ckittl 38712f6
expand transformer 3w type test
sensarmad 048757d
Adapting the equals and hash code methods for characteristics
ckittl ea90c6e
Adapting toString methods
ckittl 2884114
Only remove trailing or leading spaces of fields and not intermediate…
ckittl 6579a3d
added uuids and ids to grid element types
sensarmad 5f6f277
expand bm types test
sensarmad 44f221d
expand chp types test
sensarmad 869b8b9
Testing the reception of nodes
ckittl 5a60feb
expand hp types test
sensarmad f29ac27
expand storage types test
sensarmad 29e2130
expand ev types test
sensarmad 60775b4
expand wec types test
sensarmad 3bd1a56
Adapting the equals and hash code methods for characteristics
ckittl b0f109c
inclusion of cpCharacteristics in wec type
sensarmad 3a83536
clean up and formatting
sensarmad a2dc319
cosphi to cosphiRated in wec
sensarmad df33475
Testing the reception of lines
ckittl 8ea0f4a
remove size (number of rows) check
sensarmad 71569b7
Testing the reception of measurement units
ckittl 32dca3a
Testing the reception of switches
ckittl 03b3c38
ignore CsvThermalSourceTest for now
sensarmad 5ece189
codacy issues in CsvGraphicSourceTest
johanneshiry 297a92c
Testing the reception of two winding transformers
ckittl 8883da7
Testing the reception of three winding transformers
ckittl 4b27deb
Testing the reception of RawGridElements
ckittl d850699
removed allowed double quotes for csv rows again
johanneshiry ea56620
ValidationUtils adaptions for improved uuid duplicates check
johanneshiry 89bf935
added tests for CsvSystemParticipantSource
johanneshiry 43426ec
init branch
sensarmad eba890e
Make spotlessApply runnable
ckittl 64e6c99
Let CsvThermalSourceTest be successful. :-D
ckittl eca4d13
Merge remote-tracking branch 'remotes/origin/jh/#101-csv-raw-grid-sou…
ckittl d1ff0b0
Merge branch 'jh/#101-csv-raw-grid-source' of https://github.com/ie3-…
sensarmad ba4b8a5
Merge branch 'jh/#101-csv-raw-grid-source' of https://github.com/ie3-…
sensarmad f42e5e3
finally found a way to deal with different csvRow content incl. quote…
johanneshiry 4c978d9
fmt
johanneshiry 7f8165f
fix sonarqube logging bugs
johanneshiry 01bd8db
simplified geojson regex
johanneshiry d38eb25
addressing several sonarqube issues
johanneshiry 5e2c464
simplifying regex for sonarqube
johanneshiry c030a50
Merge branch 'ds/#101-csv-type-source-test' into jh/#101-csv-raw-grid…
johanneshiry d72e674
Merge branch 'ck/#101-csv-raw-grid-source' into jh/#101-csv-raw-grid-…
johanneshiry c221c69
Merge branch 'ck/#101-csv-raw-grid-source' into jh/#101-csv-raw-grid-…
johanneshiry c514c02
added missing test for ValidationUtils
johanneshiry ce54bed
new test in ExtractorTest
johanneshiry 2dd81f8
override equals() and hashCode() in NodeAssetInputEntityData
johanneshiry 4ad2603
fmt
johanneshiry 5ffb34a
addressing codacy issues
johanneshiry 65afb30
Merge branch 'jh/#101-csv-raw-grid-source' of https://github.com/ie3-…
sensarmad 711b153
Thermal buses test
sensarmad 55b7e46
added description for DataSource interface
johanneshiry 54d4a22
Thermal storages test
sensarmad 41effec
finished javadocs for GraphicSource + CsvGraphicSource
johanneshiry 58fcd89
added javadocs to CsvDataSource + fmt DataSource
johanneshiry e492079
Thermal unit input test
sensarmad 4274a7c
Update src/main/java/edu/ie3/datamodel/io/factory/input/TypedConnecto…
johanneshiry c9d94d4
Thermal unit input test passes
sensarmad 4241b87
Merge branch 'jh/#101-csv-raw-grid-source' of https://github.com/ie3-…
sensarmad 3d32251
- added javadocs for RawGridSource and CsvRawGridSource
johanneshiry e985fc5
switch all collections to sets to prevent passing collections where w…
johanneshiry 98f74b0
- added javadoc for SystemParticipantSource and CsvSystemParticipantS…
johanneshiry 0b6d0fc
all tests pass
sensarmad 7e42761
added javadocs to ThermalSource and CsvThermalSource
johanneshiry cc4b25d
added javadocs to TypeSource and CsvTypeSource
johanneshiry 8fd0ea5
Merge remote-tracking branch 'origin/jh/#101-csv-raw-grid-source' int…
johanneshiry d2a29d9
fix tests + fmt
johanneshiry 4f2bda1
Update src/main/java/edu/ie3/datamodel/io/factory/input/TypedConnecto…
johanneshiry 5ffa3c4
addressing reviewers comments
johanneshiry e21bf64
Update src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvDataSourceT…
johanneshiry e73de37
Update src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvDataSourceT…
johanneshiry b68ef80
Update src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvDataSourceT…
johanneshiry cd1b189
Update src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvDataSourceT…
johanneshiry bcb63d1
Update src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvGraphicSour…
johanneshiry c52c7be
addressing reviewers comments
johanneshiry 7b51305
fmt
johanneshiry 577ca0d
Merge branch 'jh/#101-csv-raw-grid-source' of github.com:ie3-institut…
johanneshiry bdd8dd6
fixing tests
johanneshiry 4c4a5ad
Use the correct Constructors for ThermalHouseInputFactory and Cylindr…
ckittl bb4e88c
Fixing what I have broken before
ckittl 8789dd2
minor formatting CsvSystemParticipantSource
johanneshiry 2179882
Merge remote-tracking branch 'remotes/origin/jh/#101-csv-raw-grid-sou…
ckittl 776ea8d
added missing javadoc + fmt
johanneshiry 23b7d46
Merge remote-tracking branch 'remotes/origin/jh/#101-csv-raw-grid-sou…
ckittl 7fd1682
Merge branch 'ds/#101-csv-thermal-source-test' into jh/#101-csv-raw-g…
johanneshiry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
src/main/java/edu/ie3/datamodel/exceptions/SourceException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /* | ||
| * © 2020. TU Dortmund University, | ||
| * Institute of Energy Systems, Energy Efficiency and Energy Economics, | ||
| * Research group Distribution grid planning and operation | ||
| */ | ||
| package edu.ie3.datamodel.exceptions; | ||
|
|
||
| /** | ||
| * Exception that should be used whenever an error occurs in a instance of a {@link | ||
| * edu.ie3.datamodel.io.source.DataSource} | ||
| * | ||
| * @version 0.1 | ||
| * @since 19.03.20 | ||
| */ | ||
| public class SourceException extends Exception { | ||
| public SourceException(final String message, final Throwable cause) { | ||
| super(message, cause); | ||
| } | ||
|
|
||
| public SourceException(final Throwable cause) { | ||
| super(cause); | ||
| } | ||
|
|
||
| public SourceException(final String message) { | ||
| super(message); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
src/main/java/edu/ie3/datamodel/io/extractor/HasThermalStorage.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /* | ||
| * © 2020. TU Dortmund University, | ||
| * Institute of Energy Systems, Energy Efficiency and Energy Economics, | ||
| * Research group Distribution grid planning and operation | ||
| */ | ||
| package edu.ie3.datamodel.io.extractor; | ||
|
|
||
| import edu.ie3.datamodel.models.input.thermal.ThermalStorageInput; | ||
|
|
||
| /** | ||
| * Interface that should be implemented by all elements holding a {@link ThermalStorageInput} | ||
| * elements and should be processable by the {@link Extractor}. | ||
| * | ||
| * @version 0.1 | ||
| * @since 31.03.20 | ||
| */ | ||
| public interface HasThermalStorage { | ||
|
|
||
| ThermalStorageInput getThermalStorage(); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.