Skip to content

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Mar 27, 2020

Resolves #73 (introduces an processor for all time series) and is based on #86.

@ckittl ckittl added the enhancement New feature or request label Mar 27, 2020
@ckittl ckittl added this to the Version 1.0 milestone Mar 27, 2020
@ckittl ckittl self-assigned this Mar 27, 2020
ckittl added 11 commits March 30, 2020 14:10
…BasedValueProcessor

# Conflicts:
#	Jenkinsfile
#	src/test/groovy/edu/ie3/datamodel/io/factory/typeinput/SystemParticipantTypeInputFactoryTest.groovy
#	src/test/groovy/edu/ie3/datamodel/io/processor/ProcessorProviderTest.groovy
#	src/test/groovy/edu/ie3/datamodel/io/processor/input/GraphicInputProcessorTest.groovy
#	src/test/groovy/edu/ie3/datamodel/io/processor/input/InputEntityProcessorTest.groovy
#	src/test/groovy/edu/ie3/test/common/GridTestData.groovy
…BasedValueProcessor

# Conflicts:
#	src/main/java/edu/ie3/datamodel/io/processor/EntityProcessor.java
#	src/test/groovy/edu/ie3/datamodel/io/processor/input/InputEntityProcessorTest.groovy
#	src/test/groovy/edu/ie3/test/common/TypeTestData.groovy
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #89 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #89      +/-   ##
===========================================
- Coverage     61.52%   61.3%   -0.23%     
- Complexity      777     813      +36     
===========================================
  Files           182     191       +9     
  Lines          3413    3574     +161     
  Branches        430     450      +20     
===========================================
+ Hits           2100    2191      +91     
- Misses         1188    1237      +49     
- Partials        125     146      +21
Impacted Files Coverage Δ Complexity Δ
...du/ie3/datamodel/models/timeseries/TimeSeries.java 40% <0%> (-43.34%) 3% <0%> (-2%)
...in/java/edu/ie3/datamodel/io/sink/CsvFileSink.java 73.17% <0%> (-20.02%) 10% <0%> (-5%)
.../java/edu/ie3/datamodel/io/FileNamingStrategy.java 78.46% <0%> (-9.78%) 19% <0%> (+1%)
...du/ie3/datamodel/io/processor/EntityProcessor.java 81.25% <0%> (-6.25%) 4% <0%> (-36%)
...atamodel/models/timeseries/HeatAndSTimeSeries.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ava/edu/ie3/datamodel/models/input/AssetInput.java 57.89% <0%> (ø) 7% <0%> (+1%) ⬆️
...u/ie3/datamodel/models/timeseries/STimeSeries.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...atamodel/models/timeseries/HeatAndPTimeSeries.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...amodel/models/timeseries/RepetitiveTimeSeries.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...u/ie3/datamodel/models/timeseries/PTimeSeries.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40f93a1...91cfd22. Read the comment docs.

@ckittl ckittl marked this pull request as ready for review April 1, 2020 07:18
@ckittl
Copy link
Member Author

ckittl commented Apr 1, 2020

All Codacy issues are addressed. Seems to be some kind of recognition problem.

@ckittl
Copy link
Member Author

ckittl commented Apr 1, 2020

This branch conceptually drifted in a direction, which is not really fitting into the overall concept. Instead of rolling everything back, I will start a new PR. Therefore, this PR is closed.

@ckittl ckittl closed this Apr 1, 2020
@ckittl ckittl deleted the ck/#73-timeBasedValueProcessor branch April 1, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend Processors to account for all subclasses of UniqueEntity + extend CsvFileSink accordingly

1 participant