Adding processor for other input entities #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
============================================
+ Coverage 60.96% 61.61% +0.64%
- Complexity 772 780 +8
============================================
Files 183 182 -1
Lines 3451 3413 -38
Branches 433 430 -3
============================================
- Hits 2104 2103 -1
+ Misses 1221 1179 -42
- Partials 126 131 +5
Continue to review full report at Codecov.
|
|
!test |
…parately in input and result processing
…tProcessor # Conflicts: # Jenkinsfile # src/test/groovy/edu/ie3/datamodel/io/factory/typeinput/SystemParticipantTypeInputFactoryTest.groovy # src/test/groovy/edu/ie3/datamodel/io/processor/ProcessorProviderTest.groovy # src/test/groovy/edu/ie3/datamodel/io/processor/input/GraphicInputProcessorTest.groovy # src/test/groovy/edu/ie3/datamodel/io/processor/input/InputEntityProcessorTest.groovy # src/test/groovy/edu/ie3/test/common/GridTestData.groovy
|
!test |
|
!test |
|
!test |
johanneshiry
suggested changes
Mar 31, 2020
src/main/java/edu/ie3/datamodel/models/input/OperatorInput.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/system/type/StorageTypeInput.java
Outdated
Show resolved
Hide resolved
johanneshiry
suggested changes
Mar 31, 2020
src/main/java/edu/ie3/datamodel/models/input/OperatorInput.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: johanneshiry <johannes.hiry@tu-dortmund.de>
|
!test |
johanneshiry
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly solves #73 (introduces an
InputEntityProcessorfor allInputEntityentities) and is based on #83.when this one is merged, we still need processors for everything that has to do with input time series.