-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support FreeGroup features for nested models #231
Conversation
Removing from beta, this can come in a minor release. |
@azeey , can this be moved from "In progress" to "In review"? |
No, this is still in-progress. I'll mark it as draft until it's ready. |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-physics4 #231 +/- ##
================================================
+ Coverage 75.30% 75.75% +0.45%
================================================
Files 125 125
Lines 5463 5503 +40
================================================
+ Hits 4114 4169 +55
+ Misses 1349 1334 -15
Continue to review full report at Codecov.
|
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, works for me! And I just learned the testing::AssertionFailure()
trick to use inside lambdas 👍
🎉 New feature
Summary
This enables FreeGroups to work with nested models
Requires:
[dartsim] Fix joint construction errors due to link name duplication or BodyNodes moving to other skeletons #220[dartsim] Ensure Link and Model APIs continue to work after joint creation in DART #227[dartsim] Add empty nested model construction and nested model entity management #228[tpe] Add empty nested model construction and nested model entity management #229Remove nested models #230Test it
nested_models.sdf
example world in ign-gazebo and use the transform tool to move the model.ign gazebo --physics-engine ignition-physics-tpe-plugin -v 4 nested_model.sdf
ign gazebo --physics-engine ignition-physics-dartsim-plugin -v 4 nested_model.sdf
Before
nested_freegroup_before.mp4
After
nested_freegroup_after.mp4
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge