Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FreeGroup features for nested models #231

Merged
merged 6 commits into from
Jul 16, 2021

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Mar 17, 2021

🎉 New feature

Summary

This enables FreeGroups to work with nested models

Requires:

Test it

  • Run tests
  • Run the nested_models.sdf example world in ign-gazebo and use the transform tool to move the model.
    • ign gazebo --physics-engine ignition-physics-tpe-plugin -v 4 nested_model.sdf
    • ign gazebo --physics-engine ignition-physics-dartsim-plugin -v 4 nested_model.sdf

Before

nested_freegroup_before.mp4

After

nested_freegroup_after.mp4

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@azeey azeey requested a review from mxgrey as a code owner March 17, 2021 11:40
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 17, 2021
@chapulina chapulina added DART DART engine enhancement New feature or request TPE Trivial Physics Engine beta Targeting beta release of upcoming collection labels Mar 17, 2021
@chapulina
Copy link
Contributor

Removing from beta, this can come in a minor release.

@chapulina chapulina removed the beta Targeting beta release of upcoming collection label Mar 25, 2021
@chapulina chapulina changed the base branch from main to ign-physics4 April 1, 2021 20:36
@iche033 iche033 requested a review from j-rivero June 7, 2021 18:42
@chapulina
Copy link
Contributor

@azeey , can this be moved from "In progress" to "In review"?

@azeey
Copy link
Contributor Author

azeey commented Jun 21, 2021

No, this is still in-progress. I'll mark it as draft until it's ready.

@azeey azeey marked this pull request as draft June 21, 2021 14:29
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey marked this pull request as ready for review June 24, 2021 23:11
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #231 (3e6b658) into ign-physics4 (164f088) will increase coverage by 0.45%.
The diff coverage is 79.31%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics4     #231      +/-   ##
================================================
+ Coverage         75.30%   75.75%   +0.45%     
================================================
  Files               125      125              
  Lines              5463     5503      +40     
================================================
+ Hits               4114     4169      +55     
+ Misses             1349     1334      -15     
Impacted Files Coverage Δ
tpe/plugin/src/FreeGroupFeatures.cc 65.93% <72.00%> (-1.18%) ⬇️
dartsim/src/FreeGroupFeatures.cc 49.46% <83.87%> (+49.46%) ⬆️
dartsim/src/EntityManagementFeatures.cc 77.48% <100.00%> (ø)
tpe/lib/src/Model.cc 92.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 164f088...3e6b658. Read the comment docs.

dartsim/src/FreeGroupFeatures.cc Outdated Show resolved Hide resolved
dartsim/src/FreeGroupFeatures.cc Outdated Show resolved Hide resolved
tpe/plugin/src/FreeGroupFeatures.cc Outdated Show resolved Hide resolved
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@scpeters scpeters mentioned this pull request Jul 15, 2021
7 tasks
azeey and others added 2 commits July 15, 2021 13:57
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works for me! And I just learned the testing::AssertionFailure() trick to use inside lambdas 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DART DART engine 🏢 edifice Ignition Edifice enhancement New feature or request TPE Trivial Physics Engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants