Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web-loading GUI: Update OK button #2851

Merged
merged 1 commit into from
May 8, 2024

Conversation

btbest
Copy link
Contributor

@btbest btbest commented Apr 26, 2024

Just a tiny improvement to the dialog for choosing a URL. Currently, the user first has to "Check URL", and if the URL gives a successful response, the Ok button is activated. If the user then changes the URL, the button remains activated and the user can add any arbitrary string to the project (which will attempt to fetch from there and fail).

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 55.74%. Comparing base (126b3e1) to head (63f99ff).
Report is 14 commits behind head on main.

Files Patch % Lines
.../applets/dataSelection/precomputedVolumeBrowser.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2851      +/-   ##
==========================================
- Coverage   55.75%   55.74%   -0.01%     
==========================================
  Files         533      533              
  Lines       62207    62213       +6     
  Branches     8511     8512       +1     
==========================================
+ Hits        34681    34683       +2     
- Misses      25767    25777      +10     
+ Partials     1759     1753       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@k-dominik k-dominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

Behavior on enter is interesting:

  • if URL is not checked, enter performs check url. if URL has been successfully checked, next enter accepts.
  • editing (e.g. adding a character), enter (unsuccessful check) -> the Unknown error while trying to connect to this address.... shows up, which is correct.
  • editing (removing character from before), Add to project becomes enabled immediately, text field doesn't change (still the Unknown error) - one enter here directly adds the data.

it's a tiny bit inconsistent.

@btbest btbest force-pushed the disable-web-gui-ok-button branch from 1e886c7 to 63f99ff Compare May 8, 2024 09:24
@btbest
Copy link
Contributor Author

btbest commented May 8, 2024

Thanks for noticing 🤦

@btbest btbest merged commit 2d44486 into ilastik:main May 8, 2024
13 of 16 checks passed
@btbest btbest deleted the disable-web-gui-ok-button branch May 8, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants