Skip to content

Conversation

sims-keshri
Copy link
Contributor

Resolved following two sonar critical code smells:

  1. Define a constant instead of duplicating this literal 'Space rocket <' 4 times.
  2. Define a constant instead of duplicating this literal "> launch complete" 3 times.

Copy link
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check CI reports for failing issues

@sims-keshri
Copy link
Contributor Author

sims-keshri commented Oct 5, 2021

Sorry for the duplication. I raised a different PR for every sonar fix that I did. All the three PRs have a different fix.

This one resolves the following two:
Define a constant instead of duplicating this literal 'Space rocket <' 4 times.
Define a constant instead of duplicating this literal "> launch complete" 3 times.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sims-keshri
Copy link
Contributor Author

sims-keshri commented Oct 5, 2021

@ohbus Have fixed the checkstyle violation.

@sims-keshri
Copy link
Contributor Author

hello @ohbus please review the PRs as I would like to make more contributions once these get approved. Thanks

Copy link
Contributor

@ohbus ohbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the changes are duplicates, carrying them forward.

Closing this in favor of #1833

@ohbus ohbus closed this Oct 8, 2021
@iluwatar iluwatar added this to the 1.25.0 milestone Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants