Skip to content

Resolve 2 Critical Sonar Code Smells #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Resolve 2 Critical Sonar Code Smells #1831

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60cf9c9
Resolve Sonar Code Smell: Define a constant instead of duplicating th…
sims-keshri Oct 4, 2021
a67cca7
Fix checkstyle violation.
sims-keshri Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions async-method-invocation/src/main/java/com/iluwatar/async/method/invocation/App.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,12 @@
@Slf4j
public class App {

private static final String ROCKET_LAUNCH_LOG_PATTERN = "Space rocket <%s> launched successfully";

/**
* Program entry point.
*/

public static void main(String[] args) throws Exception {
// construct a new executor that will run async tasks
var executor = new ThreadAsyncExecutor();
Expand All @@ -87,9 +90,9 @@ public static void main(String[] args) throws Exception {
asyncResult5.await();

// log the results of the tasks, callbacks log immediately when complete
log("Space rocket <" + result1 + "> launch complete");
log("Space rocket <" + result2 + "> launch complete");
log("Space rocket <" + result3 + "> launch complete");
log(String.format(ROCKET_LAUNCH_LOG_PATTERN, result1));
log(String.format(ROCKET_LAUNCH_LOG_PATTERN, result2));
log(String.format(ROCKET_LAUNCH_LOG_PATTERN, result3));
}

/**
Expand All @@ -102,7 +105,7 @@ public static void main(String[] args) throws Exception {
private static <T> Callable<T> lazyval(T value, long delayMillis) {
return () -> {
Thread.sleep(delayMillis);
log("Space rocket <" + value + "> launched successfully");
log(String.format(ROCKET_LAUNCH_LOG_PATTERN, value));
return value;
};
}
Expand Down