Fix for Issue #549 : Add Fallbacks in Aggregator Service #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch ClientProtocolException and Update Error Logs
Add fallbacks in Aggregator service when other microservices fail
Pull master from Source Repo
…erns into fix/issue549
iluwatar
requested changes
Oct 8, 2019
| product.setTitle("Error: Fetching Product Title Failed"); //Fallback to error message | ||
| } | ||
|
|
||
| if (productInventory != null) { |
There was a problem hiding this comment.
ProductInventoryClientImpl does not return null but 0 when exception occurs. Perhaps returning null would be the correct way, so the change should be implemented in the client..
iluwatar
added
under construction
status: under review
and removed
under construction
labels
|
Ping @jarpit96, some changes have been requested. Also the branch is conflicting now. |
|
Completely missed the comments, I will get on it soon. Will look at the conflicts too. |
Sync with original repo
…erns into fix/issue549 # Conflicts: # aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java
iluwatar
approved these changes
Nov 1, 2019
|
Thanks @jarpit96, this looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Add fall backs in Aggregator Service when other microservices fail. Default error messages (Product Title and Inventory) are returned to the user.