Skip to content

Fix for Issue #549 : Add Fallbacks in Aggregator Service #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 1, 2019
Merged

Fix for Issue #549 : Add Fallbacks in Aggregator Service #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
111e158
Fix for Issue##549
jarpit96 Oct 5, 2019
d887def
Fix indentation, checkstyle errors
jarpit96 Oct 5, 2019
606c665
Fix for Issue #549
jarpit96 Oct 7, 2019
e8b45d0
Merge pull request #1 from iluwatar/master
jarpit96 Oct 7, 2019
6639cb2
Merge branch 'master' of https://github.com/jarpit96/java-design-patt…
jarpit96 Oct 7, 2019
f091945
Merge pull request #2 from iluwatar/master
jarpit96 Nov 1, 2019
22ac6c4
Merge branch 'master' of https://github.com/jarpit96/java-design-patt…
Nov 1, 2019
c730b1f
Make ProductInventoryClientImpl return null instead of zero in case o…
Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions ...es/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,23 @@ public class Aggregator {
*/
@RequestMapping(path = "/product", method = RequestMethod.GET)
public Product getProduct() {

var product = new Product();
product.setTitle(informationClient.getProductTitle());
product.setProductInventories(inventoryClient.getProductInventories());
String productTitle = informationClient.getProductTitle();
Integer productInventory = inventoryClient.getProductInventories();

if (productTitle != null) {
product.setTitle(productTitle);
} else {
product.setTitle("Error: Fetching Product Title Failed"); //Fallback to error message
}

if (productInventory != null) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProductInventoryClientImpl does not return null but 0 when exception occurs. Perhaps returning null would be the correct way, so the change should be implemented in the client..

product.setProductInventories(productInventory);
} else {
product.setProductInventories(-1); //Fallback to default error inventory
}

return product;
}

Expand Down
2 changes: 1 addition & 1 deletion ...r-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInventoryClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@
*/
public interface ProductInventoryClient {

int getProductInventories();
Integer getProductInventories();
}
10 changes: 7 additions & 3 deletions ...rvice/src/main/java/com/iluwatar/aggregator/microservices/ProductInventoryClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ public class ProductInventoryClientImpl implements ProductInventoryClient {
private static final Logger LOGGER = LoggerFactory.getLogger(ProductInventoryClientImpl.class);

@Override
public int getProductInventories() {
var response = "0";
public Integer getProductInventories() {
var response = "";

var request = HttpRequest.newBuilder().GET().uri(URI.create("http://localhost:51516/inventories")).build();
var client = HttpClient.newHttpClient();
Expand All @@ -55,6 +55,10 @@ public int getProductInventories() {
} catch (InterruptedException ie) {
LOGGER.error("InterruptedException Occurred", ie);
}
return Integer.parseInt(response);
if("".equalsIgnoreCase(response)) {
return null;
} else {
return Integer.parseInt(response);
}
}
}