Skip to content

Conversation

kouichi-c-nakamura
Copy link
Contributor

Sorry, the branch name is wrong and confusing, but this is a bug fix for copytoImg.m MATLAB function related to permute for more than 2D image data.

bug fix for permute
@imagejan imagejan changed the title Image plus2array copytoImg: bug fix for permute Oct 11, 2018
@imagejan
Copy link
Member

Thanks for the contributions, @kouichi-c-nakamura! Sorry that there's no progress on your PRs so far. I noticed that this PR as well as #20 build on top of my migrate-matlab-scripts branch (#19), so I suggest to switch the target branch to that one, merge into it, and then leave #19 open for review (by @ctrueden ?). All of your contributions make sense and should be merged in my opinion (although I didn't get the chance to test myself with Matlab instance yet).

@imagejan imagejan changed the base branch from master to migrate-matlab-scripts October 11, 2018 12:31
@imagejan imagejan merged commit ec6951b into imagej:migrate-matlab-scripts Oct 11, 2018
@imagejan imagejan mentioned this pull request Oct 11, 2018
@kouichi-c-nakamura
Copy link
Contributor Author

No worries. I'm doing this because, if I don't do it now, I'm pretty sure that I'd forget to make PR.

Thank you.

@kouichi-c-nakamura kouichi-c-nakamura deleted the ImagePlus2array branch October 11, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants