LLVM-related refactoring #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this commit, using LLVM 3.4 & 3.5 still work and pass all tests. Using LLVM 3.6 builds and correctly runs llvmutil_test, but fails most/all testshade tests.
With this checkin, llvm 3.4 and 3.5 are fully supported and work. LLVM 3.6 builds, runs llvmuntil_test, but crashes running actual shaders. LLVM 3.7 doesn't build.
…old JIT, LLVM >= 3.6 -> MCJIT. This builds and runs properly for LLVM 3.4 and 3.5. It builds against 3.6 but fails the OSL testsuite.
|
LGTM |
lgritz
added a commit
that referenced
this pull request
Mar 10, 2016
LLVM-related refactoring: remove support for <= 3.3, work toward clean build of 3.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the middle of a concerted effort to bring us into a more modern era of LLVM versions. This set of patches is not a complete solution, but contains several intermediate steps in that direction.
#ifclauses and simplifies the structure of the code. Henceforth, LLVM 3.4 will be the minimal version we support for OSL 1.8.What this nets us is a simplification of code that will make the next steps easier. As of now (in master), we fully support and work properly with LLVM 3.4 and 3.5, and the next task will be to get some later version (maybe 3.6, or we may skip all the way to 3.7+ORC JIT, we'll see) fully working.
This whole discussion is about OSL master (what will some day be 1.8). The production release (OSL 1.7) will continue to work with LLVM 3.2 and 3.3 (though please note that I have not personally tested with either for quite some time, though I also have not purposely changed anything that would cause them to break).