-
Notifications
You must be signed in to change notification settings - Fork 42
Improve OGM & Hibernate references #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments inline.
@@ -0,0 +1,3 @@ | |||
The Hibernate team maintains the | |||
%a{:href=> "http://hibernate.org/ogm"}Hibernate OGM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use http://hibernate.org/ogm/ with a slash at the end. Let's avoid a redirection.
references.html.haml
Outdated
%h3 Hibernate ORM | ||
%p | ||
%a(href="http://www.hibernate.org") http://www.hibernate.org | ||
%a(href="http://www.hibernate.org/orm") http://www.hibernate.org/orm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
references.html.haml
Outdated
%a(name="hibernate-ogm") | ||
%h3 Hibernate OGM | ||
%p | ||
%a(href="http://www.hibernate.org/ogm") http://www.hibernate.org/ogm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
references.html.haml
Outdated
%p | ||
%a(href="http://www.hibernate.org/ogm") http://www.hibernate.org/ogm | ||
%p | ||
Hibernate OGM can perform CRUD operations on Infinispan, replacing the RDBMS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not very clear who does replace the RDBMS. And it neither fits OGM nor Infinispan.
"Hibernate OGM can perform CRUD operations on Infinispan, using Infinispan as a datastore." maybe? Or "persistent storage" but I'm not sure it fits well with Infinispan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
references.html.haml
Outdated
%a(name="hibernate-search") | ||
%h3 Hibernate Search | ||
%p | ||
%a(href="http://www.hibernate.org/search") http://www.hibernate.org/search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here for the /
references.html.haml
Outdated
%p | ||
%a(href="http://www.hibernate.org/ogm") http://www.hibernate.org/ogm | ||
%p | ||
Hibernate OGM can perform CRUD operations on Infinispan, replacing the RDBMS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "can". mention protobuf conversion. mention CRUD operation on an object graph.
%p | ||
%a(href="http://www.hibernate.org/search") http://www.hibernate.org/search | ||
%p | ||
Hibernate Search can store its Lucene index in Infinispan to provide real time replication of the index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove can.
@@ -0,0 +1,3 @@ | |||
The Hibernate team maintains the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where will this text be displayed? Does it matter that the Hibernate team maintains it? Wjat does integrate means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have published this branch on the staging site so you can look at it.
http://stg-ispn.rhcloud.com/integrations/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emmanuelbernard I felt the need to clarify that, as this will appear on the page were normally we'd host additional downloads from Infinispan.
Please see the preview: I don't think we'll want to update the release table for each OGM release.
No description provided.