Skip to content

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Mar 6, 2017

No description provided.

Copy link

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments inline.

@@ -0,0 +1,3 @@
The Hibernate team maintains the
%a{:href=> "http://hibernate.org/ogm"}Hibernate OGM
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use http://hibernate.org/ogm/ with a slash at the end. Let's avoid a redirection.

%h3 Hibernate ORM
%p
%a(href="http://www.hibernate.org") http://www.hibernate.org
%a(href="http://www.hibernate.org/orm") http://www.hibernate.org/orm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

%a(name="hibernate-ogm")
%h3 Hibernate OGM
%p
%a(href="http://www.hibernate.org/ogm") http://www.hibernate.org/ogm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

%p
%a(href="http://www.hibernate.org/ogm") http://www.hibernate.org/ogm
%p
Hibernate OGM can perform CRUD operations on Infinispan, replacing the RDBMS.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not very clear who does replace the RDBMS. And it neither fits OGM nor Infinispan.

"Hibernate OGM can perform CRUD operations on Infinispan, using Infinispan as a datastore." maybe? Or "persistent storage" but I'm not sure it fits well with Infinispan.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

%a(name="hibernate-search")
%h3 Hibernate Search
%p
%a(href="http://www.hibernate.org/search") http://www.hibernate.org/search
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here for the /

@Sanne
Copy link
Member Author

Sanne commented Mar 7, 2017

Thanks @DavideD @gsmet , applied those suggestions.

%p
%a(href="http://www.hibernate.org/ogm") http://www.hibernate.org/ogm
%p
Hibernate OGM can perform CRUD operations on Infinispan, replacing the RDBMS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "can". mention protobuf conversion. mention CRUD operation on an object graph.

%p
%a(href="http://www.hibernate.org/search") http://www.hibernate.org/search
%p
Hibernate Search can store its Lucene index in Infinispan to provide real time replication of the index.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove can.

@@ -0,0 +1,3 @@
The Hibernate team maintains the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where will this text be displayed? Does it matter that the Hibernate team maintains it? Wjat does integrate means?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have published this branch on the staging site so you can look at it.
http://stg-ispn.rhcloud.com/integrations/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuelbernard I felt the need to clarify that, as this will appear on the page were normally we'd host additional downloads from Infinispan.

Please see the preview: I don't think we'll want to update the release table for each OGM release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants