Sample app is not full screen on iPhone X

[AlirezaAkbarix]

As you can see the height of app is not properly for iPhone X

[PMExtra]

This is probably because LaunchImage was not adapt iPhoneX.
It caused the frame of UIWindow being wrong.

[morgandonze]

@AlirezaAkbarix did you find out what the issue was?

[AlirezaAkbarix]

@mlaco No! actually I found this project very messy and more complex than it should be. So I decided to create my own seed. So didn't check the problem.

[morgandonze]

@AlirezaAkbarix I'm sorry to hear that. We're working on improving this, so please check back again later if you like!

[AlirezaAkbarix]

@mlaco If you take a look at my activities on ignite boilerplates and issues I've created, you'll find out how eager am I. but I think bowser is a very messy project with some unwanted libs that can't be avoided at initial point! and also take a look at each screen and their related files. Of course typescript is the most important change, but I don't like app styles and code styles. And the last but not least, the commitment of members on project! the last (and the first) release (beta) is on 09 Jul!

[morgandonze]

Thank you, and I do apologize for not noticing your comments elsewhere, I just began working on Ignite.

[AlirezaAkbarix]

@mlaco Oh these words are my own opinion! not general! and have luck on working on this useful repo :)

[robinheinze]

I believe this is because we're missing iPhoneX slash screen assets

EDIT: I just saw that @PMExtra noticed this as well! Thanks! #76 (comment)

[robertcoopercode]

Here's the solution I came up with thanks to @PMExtra's suggestion:

1. Create a new splash screen image with dimensions 1125 x 2436 and place it in ios/AppName/Images.xcassets/LaunchImage.launchimage/. Name it LaunchImage-1125x2436@3x.png.

2. Add the following block of code to ios/AppName/Images.xcassets/LaunchImage.launchimage/Contents.json in the images array:

	{
      "orientation" : "portrait",
      "idiom" : "iphone",
      "subtype" : "2436h",
      "filename" : "LaunchImage-1125x2436@3x.png",
      "minimum-system-version" : "11.0",
      "extent" : "full-screen",
      "scale" : "3x"
    }

3. Re-run the app.

Result: