Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Add splash screen sizes for iPhoneX #100

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Conversation

robinheinze
Copy link
Member

@robinheinze robinheinze commented Sep 20, 2018

This fixes #76

I went with @leonskim 's suggestion and just added a second patch which adds the relevant files for iPhoneX

Before...
simulator screen shot - iphone x - 2018-09-20 at 14 22 47

...after
simulator screen shot - iphone x - 2018-09-20 at 14 22 51

Copy link
Member

@leonskim leonskim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat! Great job Robin! 💯

@robinheinze robinheinze merged commit 6ffe4cb into master Sep 20, 2018
@robinheinze robinheinze deleted the splash-screens-iphoneX branch September 20, 2018 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample app is not full screen on iPhone X
2 participants