This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Removes splash patches #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamonholmgren This looks good to me, since it's just the removal of the patches. The CI failures don't look related... |
robinheinze
approved these changes
Dec 3, 2018
|
Another test confirmed #131 (comment) |
This was referenced Dec 6, 2018
jamonholmgren
added a commit
that referenced
this pull request
Dec 6, 2018
* Call react-native link with spawn instead of run (#127) * Removes splash patches (#130) Note that ignite-splash will provide splash capability in the future. Check out an early implementation at: https://github.com/infinitered/ignite-splash
infinitered-circleci
pushed a commit
that referenced
this pull request
Dec 6, 2018
## [1.1.1](v1.1.0...v1.1.1) (2018-12-06) ### Bug Fixes * **cli:** Call link with spawn instead of run ([#127](#127)) ([4f9e8cb](4f9e8cb)) * **cli:** Fixes hanging on install ([c6daa0a](c6daa0a)), closes [#127](#127) [#130](#130) * **splash:** Removes splash patches ([#130](#130)) ([64340d5](64340d5))
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the splash screen patches (ref #76 and #100) because they're causing problems on bare
ignite new Foo -b ir-boilerplate-bowserprojects.I've generated a new Ignite plugin that could be run on an Ignited project with
ignite add splash. It's not ready yet (waiting on @leonskim and @robinheinze to review and fix whatever's wrong with it right now).