Initial User Defined Functions (UDFs) proto example. [WIP] #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| // | ||
| // A KeepAliveRequest/KeepAliveResponse system is used to ensure that | ||
| // the process is responsive. Every time that a KeepAliveRequest is sent | ||
| // a KeepAliveResponse must be returned within a timeout. If too many heartbeats |
There was a problem hiding this comment.
I would modify this so that any message received by Kapacitor from STDOUT should reset the timer, because the process is obviously still alive?
nathanielc
force-pushed
the
nc-issue#72
branch
3 times, most recently
from
882c01d
to
eff62a3
Compare
nathanielc
force-pushed
the
nc-issue#72
branch
4 times, most recently
from
2f2ecf9
to
41aacf4
Compare
nathanielc
force-pushed
the
nc-issue#72
branch
6 times, most recently
from
d23cd5e
to
bb816f6
Compare
|
This is nearly done. Just need to:
|
nathanielc
force-pushed
the
nc-issue#72
branch
3 times, most recently
from
cdbf1bf
to
600562b
Compare
nathanielc
force-pushed
the
nc-issue#72
branch
from
600562b
to
33f8274
Compare
nathanielc
pushed a commit
that referenced
this pull request
Jan 15, 2016
User Defined Functions (UDFs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Protocol definition for communicating with child processes.
Includes a working example in
udf_examplewhere the go code spawns the python server and communicates with it via STDIN and STDOUT.The proto file here
udf/udf.protois the meat of this PR.This example uses varint + protobuf encoded streams of data over the sockets to the process.
I decided not to use the RPC framework in proto3 since using it would require writing our own version of gRPC. More thoughts on the design are in the issue #72.