fix: only one /accounts call on app load (#6337)

* fix: remove unnecessary accounts api calls

* chore: ensure no mutation of account state

Author: wdoconnell

src/accounts/context/userAccount.tsx

@@ -1,6 +1,7 @@
 // Libraries
 import React, {FC, useCallback, useEffect, useState} from 'react'
 import {useDispatch} from 'react-redux'
+import {cloneDeep} from 'lodash'
 
 // Types
 import {UserAccount} from 'src/client/unityRoutes'
@@ -91,7 +92,6 @@ export const UserAccountProvider: FC<Props> = React.memo(({children}) => {
         setDefaultAccountId(defaultId)
       }
 
-      // isActive: true is for the currently logged in/active account
       const activeAcct = accounts.find(acct => acct.isActive === true)
       if (typeof activeAcct === 'object' && activeAcct.hasOwnProperty('id')) {
         const activeId = activeAcct.id
@@ -111,8 +111,22 @@ export const UserAccountProvider: FC<Props> = React.memo(({children}) => {
     const accountName = getAccountNameById(newDefaultAcctId)
 
     try {
+      const oldDefaultAcctId = defaultAccountId
+
       await updateDefaultQuartzAccount(newDefaultAcctId)
+
+      const accountsClone = cloneDeep(userAccounts)
+
+      accountsClone.forEach(account => {
+        if (account.id === oldDefaultAcctId) {
+          account.isDefault = false
+        }
+        if (account.id === newDefaultAcctId) {
+          account.isDefault = true
+        }
+      })
       setDefaultAccountId(newDefaultAcctId)
+      setUserAccounts(accountsClone)
 
       if (!setDefaultAccountOptions?.disablePopUps) {
         dispatch(notify(accountDefaultSettingSuccess(accountName)))
@@ -159,7 +173,7 @@ export const UserAccountProvider: FC<Props> = React.memo(({children}) => {
 
   useEffect(() => {
     handleGetAccounts()
-  }, [handleGetAccounts, defaultAccountId, activeAccountId])
+  }, [handleGetAccounts])
 
   return (
     <UserAccountContext.Provider

src/identity/components/userprofile/UserDefaults.tsx

@@ -44,7 +44,8 @@ import 'src/identity/components/userprofile/UserProfile.scss'
 export const UserDefaults: FC = () => {
   const dispatch = useDispatch()
 
-  const {userAccounts, handleSetDefaultAccount} = useContext(UserAccountContext)
+  const {defaultAccountId, handleSetDefaultAccount, userAccounts} =
+    useContext(UserAccountContext)
   const quartzOrganizations = useSelector(selectQuartzOrgs)
 
   const identity = useSelector(selectQuartzIdentity)
@@ -58,8 +59,10 @@ export const UserDefaults: FC = () => {
 
   const defaultAccount = useMemo(
     () =>
-      accounts ? accounts.find(el => el.isDefault === true) : emptyAccount,
-    [accounts]
+      accounts
+        ? accounts.find(acct => acct.id === defaultAccountId)
+        : emptyAccount,
+    [accounts, defaultAccountId]
   )
   const defaultOrg = useMemo(
     () => (orgs ? orgs.find(el => el.isDefault === true) : emptyOrg),