fix(4677): lsp helper methods need to be error handled. (#4786)

Author: wiedld

src/flows/pipes/Notification/view.tsx

@@ -42,6 +42,7 @@ import {
 } from 'src/flows/pipes/Notification/endpoints'
 import {SidebarContext} from 'src/flows/context/sidebar'
 import ExportTask from 'src/flows/pipes/Notification/ExportTask'
+import ErrorBoundary from 'src/shared/components/ErrorBoundary'
 const NotificationMonacoEditor = lazy(() =>
   import('src/flows/pipes/Notification/NotificationMonacoEditor')
 )
@@ -481,7 +482,9 @@ const Notification: FC<PipeProp> = ({Context}) => {
         </FlexBox>
         <Panel.Footer justifyContent={JustifyContent.FlexEnd}>
           <FlexBox margin={ComponentSize.Medium}>
-            <ExportTask />
+            <ErrorBoundary>
+              <ExportTask />
+            </ErrorBoundary>
           </FlexBox>
         </Panel.Footer>
       </div>

src/languageSupport/languages/flux/lsp/prelude.ts

@@ -40,7 +40,9 @@ class Prelude {
           )
         )
       }
-    } catch (_) {}
+    } catch (e) {
+      console.error(e)
+    }
   }
 
   subscribeToModel(editor: EditorType) {

src/languageSupport/languages/flux/lsp/worker/utils.ts

@@ -2,5 +2,7 @@ export const respond = (msg, cb) => {
   try {
     const d = JSON.parse(msg)
     cb(d)
-  } catch (_) {}
+  } catch (e) {
+    console.warn(e)
+  }
 }

src/timeMachine/actions/queries.ts

@@ -81,15 +81,20 @@ export const getOrgIDFromBuckets = (
   text: string,
   allBuckets: Bucket[]
 ): string | null => {
-  const ast = parse(text)
-  const bucketsInQuery: string[] = findNodes(ast, isFromBucket).map(node =>
-    get(node, 'arguments.0.properties.0.value.value', '')
-  )
+  try {
+    const ast = parse(text)
+    const bucketsInQuery: string[] = findNodes(ast, isFromBucket).map(node =>
+      get(node, 'arguments.0.properties.0.value.value', '')
+    )
 
-  // if there are buckets from multiple orgs in a query, query will error, and user will receive error from query
-  const bucketMatch = allBuckets.find(a => bucketsInQuery.includes(a.name))
+    // if there are buckets from multiple orgs in a query, query will error, and user will receive error from query
+    const bucketMatch = allBuckets.find(a => bucketsInQuery.includes(a.name))
 
-  return get(bucketMatch, 'orgID', null)
+    return get(bucketMatch, 'orgID', null)
+  } catch (e) {
+    console.error(e)
+    return null
+  }
 }
 
 // We only need a minimum of one bucket, function, and tag,

src/variables/utils/astim.ts

@@ -19,11 +19,21 @@ const parseAllVariables = (ast: File): MemberExpression[] => {
 }
 
 export const parseASTIM = (query: string): ASTIM => {
-  const ast: File = parse(query)
-  // Using `any` to circumvent ts error
-  const variables: any = ast ? parseAllVariables(ast) : []
+  let ast: File = null
+  try {
+    ast = parse(query)
+  } catch (e) {
+    console.error(e)
+  }
+  const variables: MemberExpression[] = ast ? parseAllVariables(ast) : []
   const variableNames = new Set()
-  variables.forEach(variable => variableNames.add(variable.property.name))
+  variables.forEach(variable => {
+    if (variable.property.type === 'Identifier') {
+      variableNames.add(variable.property.name)
+    } else if (variable.property.type === 'StringLiteral') {
+      variableNames.add(variable.property.value)
+    }
+  })
 
   const hasVariable = (v: string): boolean => {
     return variableNames.has(v)

src/writeData/components/ClientCodeQueryHelper.tsx

@@ -50,18 +50,21 @@ const ClientCodeQueryHelper: FC<Props> = ({clientQuery, contentID}) => {
       changeQuery(def.query)
       return
     }
-
-    const ast = parse(clientQuery)
-    const queryBucket = getBucketsFromAST(ast)[0]
-    if (queryBucket) {
-      changeBucket({name: queryBucket} as Bucket)
-    }
-    updateBucketInAST(ast, '<%= bucket %>')
-    let query = format_from_js_file(ast)
-    if (def.querySanitize) {
-      query = def.querySanitize(query)
+    try {
+      const ast = parse(clientQuery)
+      const queryBucket = getBucketsFromAST(ast)[0]
+      if (queryBucket) {
+        changeBucket({name: queryBucket} as Bucket)
+      }
+      updateBucketInAST(ast, '<%= bucket %>')
+      let query = format_from_js_file(ast)
+      if (def.querySanitize) {
+        query = def.querySanitize(query)
+      }
+      changeQuery(query)
+    } catch (e) {
+      console.error(e)
     }
-    changeQuery(query)
   }, [clientQuery, def.query, changeBucket, changeQuery])
 
   return null