fix(globalHeader): Global header typeahead menu item height (#5908)

ChitlangeSahas · web-flow · commit 2897e89d0179 · 2022-09-27T11:43:24.000-06:00
* fix(globalHeader): fix styling on typeahead menu items

* fix(globalHeader): fix styling on typeahead menu items
diff --git a/src/identity/components/GlobalHeader/GlobalHeaderDropdown/GlobalHeaderDropdown.scss b/src/identity/components/GlobalHeader/GlobalHeaderDropdown/GlobalHeaderDropdown.scss
@@ -64,6 +64,7 @@
 .global-header--typeahead-item {
   width: 100%;
   padding-left: 14px;
+  height: 36px;
 }
 
 .line-break {
diff --git a/src/identity/components/GlobalHeader/GlobalHeaderDropdown/GlobalHeaderTypeAheadMenu.tsx b/src/identity/components/GlobalHeader/GlobalHeaderDropdown/GlobalHeaderTypeAheadMenu.tsx
@@ -29,7 +29,7 @@ type State = {
 }
 
 export class GlobalHeaderTypeAheadMenu extends React.Component<Props, State> {
-  private listItemHeight = 50
+  private listItemHeight = 54
   private maxDropdownHeight = 150
   constructor(props: Props) {
     super(props)
diff --git a/src/identity/components/GlobalHeader/GlobalHeaderDropdown/index.tsx b/src/identity/components/GlobalHeader/GlobalHeaderDropdown/index.tsx
@@ -205,7 +205,7 @@ export class GlobalHeaderDropdown extends React.Component<Props, State> {
                 justifyContent={JustifyContent.SpaceBetween}
                 alignItems={AlignItems.Center}
               >
-                <span className="global-header--align-center">
+                <span className="global-header--main-dropdown-item">
                   {iconEl}
                   {textEl}
                 </span>

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,7 @@`
`64`	`64`	`.global-header--typeahead-item {`
`65`	`65`	`width: 100%;`
`66`	`66`	`padding-left: 14px;`
	`67`	`+ height: 36px;`
`67`	`68`	`}`
`68`	`69`
`69`	`70`	`.line-break {`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ type State = {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`export class GlobalHeaderTypeAheadMenu extends React.Component<Props, State> {`
`32`		`- private listItemHeight = 50`
	`32`	`+ private listItemHeight = 54`
`33`	`33`	`private maxDropdownHeight = 150`
`34`	`34`	`constructor(props: Props) {`
`35`	`35`	`super(props)`
Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ export class GlobalHeaderDropdown extends React.Component<Props, State> {`
`205`	`205`	`justifyContent={JustifyContent.SpaceBetween}`
`206`	`206`	`alignItems={AlignItems.Center}`
`207`	`207`	`>`
`208`		`- <span className="global-header--align-center">`
	`208`	`+ <span className="global-header--main-dropdown-item">`
`209`	`209`	`{iconEl}`
`210`	`210`	`{textEl}`
`211`	`211`	`</span>`